Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965208AbbEMOD4 (ORCPT ); Wed, 13 May 2015 10:03:56 -0400 Received: from mail-yk0-f170.google.com ([209.85.160.170]:33367 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933470AbbEMODy (ORCPT ); Wed, 13 May 2015 10:03:54 -0400 MIME-Version: 1.0 In-Reply-To: <1429797494-29242-5-git-send-email-ricardo.ribalda@gmail.com> References: <1429797494-29242-1-git-send-email-ricardo.ribalda@gmail.com> <1429797494-29242-5-git-send-email-ricardo.ribalda@gmail.com> From: Rob Herring Date: Wed, 13 May 2015 09:03:31 -0500 Message-ID: Subject: Re: [PATCH v4 4/4] base/platform: Remove code duplication To: Ricardo Ribalda Delgado Cc: Greg Kroah-Hartman , Grant Likely , Rob Herring , Andrew Morton , Jakub Sitnicki , Vivek Goyal , Bjorn Helgaas , Jiang Liu , Mike Travis , Thierry Reding , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3739 Lines: 109 On Thu, Apr 23, 2015 at 8:58 AM, Ricardo Ribalda Delgado wrote: > Failure path of platform_device_add was almost the same as > platform_device_del. Refactor same code in a function. > > Signed-off-by: Ricardo Ribalda Delgado Clean-ups should come first in the series. Otherwise: Acked-by: Rob Herring > --- > drivers/base/platform.c | 60 +++++++++++++++++++++---------------------------- > 1 file changed, 25 insertions(+), 35 deletions(-) > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index 2e7e904..152d84d 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -298,6 +298,25 @@ int platform_device_add_data(struct platform_device *pdev, const void *data, > } > EXPORT_SYMBOL_GPL(platform_device_add_data); > > +static void platform_device_cleanout(struct platform_device *pdev, int n_res) > +{ > + int i; > + > + if (pdev->id_auto) { > + ida_simple_remove(&platform_devid_ida, pdev->id); > + pdev->id = PLATFORM_DEVID_AUTO; > + } > + > + for (i = 0; i < n_res; i++) { > + struct resource *r = &pdev->resource[i]; > + unsigned long type = resource_type(r); > + > + if ((type == IORESOURCE_MEM || type == IORESOURCE_IO) && > + r->parent) > + release_resource(r); > + } > +} > + > /** > * platform_device_add - add a platform device to device hierarchy > * @pdev: platform device we're adding > @@ -371,23 +390,8 @@ int platform_device_add(struct platform_device *pdev) > dev_name(&pdev->dev), dev_name(pdev->dev.parent)); > > ret = device_add(&pdev->dev); > - if (ret == 0) > - return ret; > - > - /* Failure path */ > - if (pdev->id_auto) { > - ida_simple_remove(&platform_devid_ida, pdev->id); > - pdev->id = PLATFORM_DEVID_AUTO; > - } > - > - while (--i >= 0) { > - struct resource *r = &pdev->resource[i]; > - unsigned long type = resource_type(r); > - > - if ((type == IORESOURCE_MEM || type == IORESOURCE_IO) && > - r->parent) > - release_resource(r); > - } > + if (ret) > + platform_device_cleanout(pdev, i); > > return ret; > } > @@ -403,25 +407,11 @@ EXPORT_SYMBOL_GPL(platform_device_add); > */ > void platform_device_del(struct platform_device *pdev) > { > - int i; > - > - if (pdev) { > - device_del(&pdev->dev); > - > - if (pdev->id_auto) { > - ida_simple_remove(&platform_devid_ida, pdev->id); > - pdev->id = PLATFORM_DEVID_AUTO; > - } > - > - for (i = 0; i < pdev->num_resources; i++) { > - struct resource *r = &pdev->resource[i]; > - unsigned long type = resource_type(r); > + if (!pdev) > + return; > > - if ((type == IORESOURCE_MEM || type == IORESOURCE_IO) && > - r->parent) > - release_resource(r); > - } > - } > + device_del(&pdev->dev); > + platform_device_cleanout(pdev, pdev->num_resources); > } > EXPORT_SYMBOL_GPL(platform_device_del); > > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/