Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965266AbbEMO76 (ORCPT ); Wed, 13 May 2015 10:59:58 -0400 Received: from forward18h.cmail.yandex.net ([87.250.230.160]:56187 "EHLO forward18h.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934425AbbEMO74 (ORCPT ); Wed, 13 May 2015 10:59:56 -0400 From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: David Fries , Greg Kroah-Hartman Cc: Thorsten Bschorr , Jonathan ALIBERT , "linux-kernel@vger.kernel.org" In-Reply-To: <20150509005150.GL32351@spacedout.fries.net> References: <20150509005150.GL32351@spacedout.fries.net> Subject: Re: [PATCH] w1_therm reference count family data MIME-Version: 1.0 Message-Id: <5969431431529191@web10h.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Wed, 13 May 2015 17:59:51 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 27 Hi 09.05.2015, 03:52, "David Fries" : > A temperature conversion can take 750 ms and when possible the > w1_therm slave driver drops the bus_mutex to allow other bus > operations, but that includes operations such as a periodic slave > search, which can remove this slave when it is no longer detected. > If that happens the sl->family_data will be freed and set to NULL > causing w1_slave_show to crash when it wakes up. > > Signed-off-by: David Fries > Reported-By: Thorsten Bschorr > Tested-by: Thorsten Bschorr > Acked-by: Evgeniy Polyakov > --- > This should be applied to the stable series as well. ?In the name of > full disclosure, this just narrows the race window, from crashing in > normal operation on the reporters system to no longer crashing with > multiple readers and another process hammering on inserting/removing > the slave device. Greg, please pull it upstream -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/