Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934597AbbEMPAz (ORCPT ); Wed, 13 May 2015 11:00:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35295 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934578AbbEMPAv (ORCPT ); Wed, 13 May 2015 11:00:51 -0400 From: Jeff Moyer To: Jens Axboe Cc: Shaohua Li , Subject: Re: [PATCH] blk: don't account discard request size References: <10cba6675b3e93f28b9c1c7a21e4b93b923e9531.1431467011.git.shli@fb.com> <55535D9C.3050706@fb.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Wed, 13 May 2015 11:00:49 -0400 In-Reply-To: <55535D9C.3050706@fb.com> (Jens Axboe's message of "Wed, 13 May 2015 10:20:12 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 18 Jens Axboe writes: > That would be better. But I'm still not sure we want to turn off > accounting for discards. For the mixed write/discard cases it's > definitely confusing. The better option would be to account it as a > discard and not a write. Preferably in a way that would not break > existing tools, but so that they could get updated to support it. Are you suggesting adding a few fields to the end of diskstats or adding a new proc file altogether? (or something else?) Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/