Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965038AbbEMQtu (ORCPT ); Wed, 13 May 2015 12:49:50 -0400 Received: from mga01.intel.com ([192.55.52.88]:51614 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964875AbbEMQts (ORCPT ); Wed, 13 May 2015 12:49:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,421,1427785200"; d="scan'208";a="694397985" Date: Wed, 13 May 2015 12:49:45 -0400 From: Matthew Wilcox To: Nicholas Krause Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block:Remove including of the header file, linux/mm.h for the file,nvme-core.c Message-ID: <20150513164945.GX4003@linux.intel.com> References: <1431534078-17740-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431534078-17740-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 17 On Wed, May 13, 2015 at 12:21:18PM -0400, Nicholas Krause wrote: > This removes the include statement for including the header file, > linux/mm.h in the file, nvme-core.c due this driver file never > calling any functions from the header file, linux/mm.h and > only adding bloat to this driver by including this unnessary > header file. Nick, I'm not going to apply this patch, simply because the effort of verifying that you haven't made a mistake is greater than the gain we might get from applying it. Your earlier patch shows that you haven't actually learned anything since I first heard about your patches. Please, continue learning before submitting more patches. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/