Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934559AbbEMTDd (ORCPT ); Wed, 13 May 2015 15:03:33 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:58345 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933957AbbEMTDc (ORCPT ); Wed, 13 May 2015 15:03:32 -0400 From: Arnd Bergmann To: Hans Ulli Kroll Cc: Paul Bolle , Alexandre Belloni , linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 1/1] RTC:driver for Cortina's SOC Date: Wed, 13 May 2015 21:03:29 +0200 Message-ID: <4603623.ImT6VbfUHq@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1431361537-10473-1-git-send-email-ulli.kroll@googlemail.com> <3450432.fQTk5fWsso@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:bxzg7WlP+/9+MEwQD5d9q/TUhU3CX5EPGlYFg0+DmM3jntGr8kj R+Vux4izUklK58arWjbA+zLRBMYe1bvGZAruXk67fzD2NSpWaE9OeN+67xiYGYUJOMl83e/ 3Ybj8ipPXiUwZEbJZFl4G2/sq+6t1eZWEY5KU6bciyU7qerPhoKVzZQmEWCRnsVy8XM4tCO 1s1EmPPDLHKnn7y24r1Vg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 22 On Wednesday 13 May 2015 20:23:40 Hans Ulli Kroll wrote: > > I have a patch that will turn mach-gemini into multiplatform, and > > at that point it will also fail there. The correct solution I think > > is to move the GEMINI_RTC_SECOND etc definitions into rtc-gemini.c > > itself and remove the #include. > > > > GEMINI_RTC_SECOND and other register offset are in the driver. > The only address I get from the #include is the base address of the RTC > Ah, I see. Please pass a struct resource for this then when you call platform_device_register_simple from the platform code, and use platform_get_resource/devm_ioremap_resource to map it so you can remove that inclusion. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/