From: Arnd Bergmann <arnd@arndb.de>
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/1] RTC:driver for Cortina's SOC
Date: Wed, 13 May 2015 21:05:54 +0200
Message-ID: <48345244.4lEG5ioxP8@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <4603623.ImT6VbfUHq@wuerfel>
References: <1431361537-10473-1-git-send-email-ulli.kroll@googlemail.com> <alpine.LNX.2.00.1505132018440.12985@T520.local> <4603623.ImT6VbfUHq@wuerfel>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1335
Lines: 29

On Wednesday 13 May 2015 21:03:29 Arnd Bergmann wrote:
> From:	Arnd Bergmann <arnd@arndb.de>
> To:	Hans Ulli Kroll <ulli.kroll@googlemail.com>
> CC:	Paul Bolle <pebolle@tiscali.nl>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, linux-kernel@vger.kernel.org
> Date:	Today 21:03:29
> On Wednesday 13 May 2015 20:23:40 Hans Ulli Kroll wrote:
> > > I have a patch that will turn mach-gemini into multiplatform, and
> > > at that point it will also fail there. The correct solution I think
> > > is to move the GEMINI_RTC_SECOND etc definitions into rtc-gemini.c
> > > itself and remove the #include.
> > > 
> > 
> > GEMINI_RTC_SECOND and other register offset are in the driver.
> > The only address I get from the #include is the base address of the RTC
> > 
> 
> Ah, I see. Please pass a struct resource for this then when you call
> platform_device_register_simple from the platform code, and
> use platform_get_resource/devm_ioremap_resource to map it so you can
> remove that inclusion.

I just saw that you already do this, so the #include should not be needed at all.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/