Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754489AbbEMUG7 (ORCPT ); Wed, 13 May 2015 16:06:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48064 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753207AbbEMUG6 (ORCPT ); Wed, 13 May 2015 16:06:58 -0400 Date: Wed, 13 May 2015 22:06:56 +0200 From: Michal Kubecek To: roopa Cc: Nicolas Dichtel , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy Subject: Re: [PATCH net 1/2] ipv6: do not delete previously existing ECMP routes if add fails Message-ID: <20150513200656.GA31076@unicorn.suse.cz> References: <4e3d075f2be93d9655bc1372a107584368a29eab.1431500953.git.mkubecek@suse.cz> <55534389.8070307@6wind.com> <20150513124940.GB27366@unicorn.suse.cz> <555351EC.9050805@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555351EC.9050805@cumulusnetworks.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 23 On Wed, May 13, 2015 at 06:30:20AM -0700, roopa wrote: > > > This looks like a similar bug i was trying to fix some time back: > http://patchwork.ozlabs.org/patch/362296/ > > (I am not sure if my full patch is still valid. I was thinking of > re-spining it sometime soon. If you are interested in trying it out, > please do) It's essentially the same idea but I prefer to use variable remaining which is already there and is needed anyway rather than introduce three extra variables for the cleanup (which is quite similar to the suggestion from Hannes' reply). I've sent v2 few minutes ago. Michal Kubecek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/