Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965184AbbEMUzL (ORCPT ); Wed, 13 May 2015 16:55:11 -0400 Received: from down.free-electrons.com ([37.187.137.238]:51454 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752850AbbEMUzG (ORCPT ); Wed, 13 May 2015 16:55:06 -0400 Date: Wed, 13 May 2015 22:51:22 +0200 From: Maxime Ripard To: Kevin Hilman Cc: Stephen Boyd , Heiko =?iso-8859-1?Q?St=FCbner?= , Mike Turquette , Doug Anderson , linux-clk@vger.kernel.org, lkml , "linux-arm-kernel@lists.infradead.org" , Boris Brezillon , Alex Elder , Alexandre Belloni , Stephen Warren , Max Filippov , Sascha Hauer , Zhangfei Gao , Santosh Shilimkar , Chao Xie , Jason Cooper , Stefan Wahren , Andrew Bresticker , Robert Jarzmik , Georgi Djakov , Sylwester Nawrocki , Geert Uytterhoeven , Barry Song , Dinh Nguyen , Viresh Kumar , Gabriel FERNANDEZ , Emilio =?iso-8859-1?Q?L=F3pez?= , Peter De Sc hrijver , Tero Kristo , Ulf Hansson , Pawel Moll , Michal Simek , Olof Johansson , Tyler Baker Subject: Re: [PATCH v3 0/2] clk: improve handling of orphan clocks Message-ID: <20150513205122.GK4004@lukather> References: <22709390.NTAlubMgNB@diego> <55440EDA.4030905@codeaurora.org> <554BD33D.7050907@codeaurora.org> <20150508100247.GQ11057@lukather> <55528046.4030107@codeaurora.org> <20150513130304.GA4004@lukather> <7hiobw8s31.fsf@deeprootsystems.com> <20150513201426.GH4004@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BFVE2HhgxTpCzM8t" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4711 Lines: 122 --BFVE2HhgxTpCzM8t Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 13, 2015 at 01:44:50PM -0700, Kevin Hilman wrote: > On Wed, May 13, 2015 at 1:14 PM, Maxime Ripard > wrote: > > On Wed, May 13, 2015 at 07:33:54AM -0700, Kevin Hilman wrote: > >> Maxime Ripard writes: > >> > >> > On Tue, May 12, 2015 at 03:35:50PM -0700, Stephen Boyd wrote: > >> >> On 05/08/15 03:02, Maxime Ripard wrote: > >> >> > On Thu, May 07, 2015 at 02:03:57PM -0700, Stephen Boyd wrote: > >> >> >> On 05/07/15 08:17, Kevin Hilman wrote: > >> >> >>> On Fri, May 1, 2015 at 4:40 PM, Stephen Boyd wrote: > >> >> >>>> On 05/01/15 15:07, Heiko St=FCbner wrote: > >> >> >>>>> Am Freitag, 1. Mai 2015, 13:52:47 schrieb Stephen Boyd: > >> >> >>>>> > >> >> >>>>>>> Instead I guess we could hook it less deep into clk_get_sys= , like in the > >> >> >>>>>>> following patch? > >> >> >>>>>> It looks like it will work at least, but still I'd prefer to= keep the > >> >> >>>>>> orphan check contained to clk.c. How about this compile test= ed only patch? > >> >> >>>>> I gave this a spin on my rk3288-firefly board. It still boots= , the clock tree > >> >> >>>>> looks the same and it also still defers nicely in the scenari= o I needed it > >> >> >>>>> for. The implementation also looks nice - and of course much = more compact than > >> >> >>>>> my check in two places :-) . I don't know if you want to put = this as follow-up > >> >> >>>>> on top or fold it into the original orphan-check, so in any c= ase > >> >> >>>>> > >> >> >>>>> Tested-by: Heiko Stuebner > >> >> >>>>> Reviewed-by: Heiko Stuebner > >> >> >>>> Thanks. I'm leaning towards tossing your patch 2/2 and replaci= ng it with > >> >> >>>> my patch and a note that it's based on an earlier patch from y= ou. > >> >> >>> It appears this has landed in linux-next in the form of 882667c= 1fcf1 > >> >> >>> clk: prevent orphan clocks from being used. A bunch of boot fa= ilures > >> >> >>> for sunxi in today's linux-next[1] were bisected down to that p= atch. > >> >> >>> > >> >> >>> I confirmed that reverting that commit on top of next/master ge= ts > >> >> >>> sunxi booting again. > >> >> >>> > >> >> >>> > >> >> >> Thanks for the report. I've removed the two clk orphan patches f= rom > >> >> >> clk-next. Would it be possible to try with next-20150507 and > >> >> >> clk_ignore_unused on the command line? > >> >> > This makes it work, but it's not really an option. > >> >> > > >> >> > >> >> Hmm.. I thought it didn't fix it for Kevin. Confused. > >> > > >> > I'm too, but it does fix things here. > >> > >> To be more precise on what I tested. I used next-20150507 and tested = on > >> 4 different sunxi platforms. First test was "normal" commandline, > >> second was with clk_ignore_unused appended: > >> > >> - cubie: fail, fail > >> - cubie2: fail, fail > >> - bananpi: fail, pass > >> - cubietruck: fail, pass > >> > >> So it seems to have some effect, but by itself, doesn't fix the issue. > > > > It's very odd, I actually tried with a cubie2 here... > > > > I'm booting on an initramfs and not MMC though, but I can't see how > > that can be related to our issue... >=20 > I'm booting an initramfs too. Then I don't know :) --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --BFVE2HhgxTpCzM8t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVU7lKAAoJEBx+YmzsjxAgGl4P/jJdtDm+UuAhFJ93JYJVlbgG P6DVnTZUZClD2EG8uhX3AgcdWr1Sq5BpeMLLb5erhH92DxAdHm6rUnhxabRxsC7n 5I/MkMkcKx7pmvhnzpaQQi+ZaSoib8pD4LCbjrN4jtGGWjnDNX4uIeumh1hSby4E cczEx/oDOkH3aMTQtPoNxKn/aWBltc7vru/9fA9cwpVAea5PCzomV5J6CQtY0cgM BcOXJ1wRDGq0uIaUJq0ARvYBlSNOjGwIwPYBClYwE4PgcSHPcEeq17JAAjarP/1E MTrcXnHJOgKcp8LJYOhrQhW72btot68stTAIg6SaX8HB9JU/ZI/6mazlNOP2bKFV 25gJ7rDki3wXgLUrBG5YJlSjnzbh9R5/Pood9xCfS5QVtKKZrwMTwwIENHgTR2H3 0Up4y+RACVqSM0ZI0/YbKmw2zEWXNRLmSxBDXkh0BZCD5XsdCoVF31Z3pnM1Zgxn Avwc65Z362EC6QCVpidt+8qguDadOzliuptm3DED25D7WUFkhhSvc2+DXdKAM9u3 0cNh9ykHeWDG3OpglMNi6tYXVSUP5QwfeO2DQX5gp7sE9sXERkXispcPnelBZUMY sNUPD0CyAgtMGf8l37k+eUOUQ2AzZ/ziaZAzjJ8FPRCeSPG2kL5ocrjOKcDZ8Aw6 k9+l5VoqthyYj6HpcJJy =CJeD -----END PGP SIGNATURE----- --BFVE2HhgxTpCzM8t-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/