Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754508AbbEMVrE (ORCPT ); Wed, 13 May 2015 17:47:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56180 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393AbbEMVrA (ORCPT ); Wed, 13 May 2015 17:47:00 -0400 Date: Wed, 13 May 2015 14:46:59 -0700 From: Andrew Morton To: Daniel Wagner Cc: Rasmus Villemoes , Subject: Re: [PATCH v1] lib/sort: Add 64 bit swap function Message-Id: <20150513144659.15aea69ece3e3a9b9a2770f5@linux-foundation.org> In-Reply-To: <55533561.4090001@bmw-carit.de> References: <87egml7sn6.fsf@rasmusvillemoes.dk> <1431514812-9946-1-git-send-email-daniel.wagner@bmw-carit.de> <55533561.4090001@bmw-carit.de> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 698 Lines: 23 On Wed, 13 May 2015 13:28:33 +0200 Daniel Wagner wrote: > On 05/13/2015 01:00 PM, Daniel Wagner wrote: > > static int cmp_72(const void *a, const void *b) > > { > > u32 l = get_unaligned((u32 *) a); > > u32 r = get_unaligned((u32 *) b); > > > > if (l < r) > > return -1; > > if (l > r) > > return -1; > > return 0; > > } > > Argh, obviously wrong. Should I send a fix? The numbers do not change. I fixed it up. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/