Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934589AbbEMWHu (ORCPT ); Wed, 13 May 2015 18:07:50 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:57485 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933971AbbEMWHt (ORCPT ); Wed, 13 May 2015 18:07:49 -0400 Date: Wed, 13 May 2015 18:07:44 -0400 (EDT) Message-Id: <20150513.180744.973850573845788118.davem@davemloft.net> To: alexander.h.duyck@redhat.com Cc: linux-kernel@vger.kernel.org, balbi@ti.com, tony@atomide.com, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [net-next PATCH] net: Reserve skb headroom and set skb->dev even if using __alloc_skb From: David Miller In-Reply-To: <20150513203413.8252.98057.stgit@ahduyck-vm-fedora22> References: <20150513182738.GA28201@saruman.tx.rr.com> <20150513203413.8252.98057.stgit@ahduyck-vm-fedora22> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 May 2015 15:07:48 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 19 From: Alexander Duyck Date: Wed, 13 May 2015 13:34:13 -0700 > When I had inlined __alloc_rx_skb into __netdev_alloc_skb and > __napi_alloc_skb I had overlooked the fact that there was a return in the > __alloc_rx_skb. As a result we weren't reserving headroom or setting the > skb->dev in certain cases. This change corrects that by adding a couple of > jump labels to jump to depending on __alloc_skb either succeeding or failing. > > Fixes: 9451980a6646 ("net: Use cached copy of pfmemalloc to avoid accessing page") > Reported-by: Felipe Balbi > Signed-off-by: Alexander Duyck Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/