Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934621AbbEMWJE (ORCPT ); Wed, 13 May 2015 18:09:04 -0400 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:53155 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933971AbbEMWJA (ORCPT ); Wed, 13 May 2015 18:09:00 -0400 Date: Wed, 13 May 2015 23:08:44 +0100 From: One Thousand Gnomes To: Bin Gao Cc: Greg Kroah-Hartman , Peter Hurley , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: serial_core: add pci uart early console support Message-ID: <20150513230844.1d9a5d9a@lxorguk.ukuu.org.uk> In-Reply-To: <20150513192016.GA167188@worksta> References: <20150513192016.GA167188@worksta> Organization: Intel Corporation X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1357 Lines: 34 On Wed, 13 May 2015 12:20:16 -0700 Bin Gao wrote: > >From 8977941ac3d70425fa7ca5ef3ab6de6c28743f1f Mon Sep 17 00:00:00 2001 > From: Bin Gao > Date: Tue, 12 May 2015 16:40:27 -0700 > Subject: [PATCH] serial_core: add pci uart early console support > > On some Intel Atom SoCs, the legacy IO port UART(0x3F8) is not available. > Instead, a 8250 compatible PCI uart can be used as early console. > This patch adds pci support to the 8250 early console driver uart8250. > For example, to enable pci uart(00:21.3) as early console on these > platforms, append the following line to the kernel command line > (assume baud rate is 115200): > earlycon=uart8250,pci32,0:24.2,115200n8 We've already got support for this commit ea9e9d8029020d438b0717ffddf65140fda16051 I actually think the fact you've put it into drivers/tty is better as PCI is generic and PCI serial boot likewise. However it ought to use the same command line interface (with extensions) to be compatible with the existing arch/x86 code, and to remove the arch/x86 version if you are doing so. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/