Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934689AbbEMXLh (ORCPT ); Wed, 13 May 2015 19:11:37 -0400 Received: from mail-vn0-f51.google.com ([209.85.216.51]:35930 "EHLO mail-vn0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934606AbbEMXLf convert rfc822-to-8bit (ORCPT ); Wed, 13 May 2015 19:11:35 -0400 MIME-Version: 1.0 In-Reply-To: References: <1431422797-31903-1-git-send-email-zhengxing@rock-chips.com> <1431422797-31903-2-git-send-email-zhengxing@rock-chips.com> <20150512192215.GZ3066@sirena.org.uk> <55535035.5070608@rock-chips.com> <20150513164250.GB2761@sirena.org.uk> From: Dylan Reid Date: Wed, 13 May 2015 16:11:14 -0700 X-Google-Sender-Auth: dLfG_QphnnnARRwF8QdsLBfsLo4 Message-ID: Subject: Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver To: Mark Brown Cc: zhengxing , Xing Zheng , Douglas Anderson , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Sonny Rao , linux-rockchip@lists.infradead.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2329 Lines: 48 On Wed, May 13, 2015 at 10:21 AM, Dylan Reid wrote: > On Wed, May 13, 2015 at 9:42 AM, Mark Brown wrote: >> On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: >>> On 2015年05月13日 03:22, Mark Brown wrote: >> >>> >Is it not possible to extend simple card to handle your use cases? >>> >Given the very generic naming and the fact that things like jack >>> >detection and so on should depend on the CODEC and board usually rather >>> >than on the SoC it doesn't sound like this is Rockchip specific. >> >>> >This also looks like you're reimplementing some device model enumeration >>> >stuff which probably shouldn't be happening but let's understand the >>> >problem you're trying to solve here before going too far into the code. >> >>> Because we are trying to bring rt5650 in the project, so we intend to >>> describe supported codecs with DTS via only a rockchip machine driver file, >>> others remain pre-implement(like max98090 / rt5645 that vendor machine >>> driver). >> >> I don't undertand what you're saying here, sorry - why is this not just >> a case of writing multiple machine drivers? > > I don't understand this either. I'd think the best solution is > simple-card, configured through DTS for each device. > >> >>> I communicated with Dylan, and he told me that the jack detection is an >>> issue in the simple-card, and suggested we are better to send them at >>> present. >> >> But what are these issues? > > The issue I was referring to when I spoke with rock chip was the need > to pass the jack simple-card creates to the headset chip or codec. We > need a way to specify a device like a tsa227e or rt5650 to pass the > jack to, which events are supported by the jack, and a generic API for > passing the jack. I'm having some trouble envisioning how to pass the jack to the headset chip in a generic way. A callback could be added to snd_soc_component_driver, or a snd_soc_headset_driver could be added. The headset_drive would fit the ts3a227e well, but not the rt5645 which is also a full blown codec. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/