Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753603AbbEMXfI (ORCPT ); Wed, 13 May 2015 19:35:08 -0400 Received: from mga01.intel.com ([192.55.52.88]:57504 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbbEMXfF (ORCPT ); Wed, 13 May 2015 19:35:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,424,1427785200"; d="scan'208";a="493311369" User-Agent: Microsoft-MacOutlook/14.4.8.150116 Date: Wed, 13 May 2015 16:34:54 -0700 Subject: Re: [PATCH v4 0/6] selftests: Add futex functional tests From: Darren Hart To: Shuah Khan , Linux Kernel Mailing List CC: , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Davidlohr Bueso , KOSAKI Motohiro , Message-ID: Thread-Topic: [PATCH v4 0/6] selftests: Add futex functional tests References: <5553DCAE.2010208@osg.samsung.com> In-Reply-To: <5553DCAE.2010208@osg.samsung.com> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6690 Lines: 191 On 5/13/15, 4:22 PM, "Shuah Khan" wrote: >On 05/12/2015 10:07 PM, Darren Hart wrote: >> Hi Shuah, >> >> This series begins the process of migrating my futextest tests into >>kselftest. >> I've started with only the functional tests, as the performance and >>stress may >> not be appropriate for kselftest as they stand. >> >> I cleaned up various complaints from checkpatch, but I ignored others >>that would >> require significant rework of the testcases, such as not using volatile >>and not >> creating new typedefs. >> > >Daren, > >This patch series is good. kselftest run and install >are good. I see the following results. Something you >would expect?? Yes, that is all expected behavior if you don't run as root and your user doesn't have the necessary capabilities added - similar to other tests with privileged operations. > No Issues and I am going to get them >into 4.2 - should show up in linux-kselftest next. Great, thanks. Perhaps some explicit capabilities tests and clearer error messages would make sense as a follow-on patch. Thanks for working with me to get these into the kernel, I think it will improve futex test exposure and hopefully encourage people to write more tests to fill some of the gaps. -- Darren > >Thanks for adding these. > >thanks, >-- Shuah > >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=0 owner=0 timeout=0ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=0 owner=0 timeout=0ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=1 owner=0 timeout=0ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=0 owner=1 timeout=0ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating third party blocker thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=1 owner=0 timeout=0ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=0 owner=1 timeout=0ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating third party blocker thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=1 owner=0 timeout=5000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=1 owner=0 timeout=5000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=1 owner=0 timeout=500000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=1 owner=0 timeout=500000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=0 owner=0 timeout=5000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=0 owner=0 timeout=5000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=0 owner=0 timeout=500000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=0 owner=0 timeout=500000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=0 owner=1 timeout=5000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating third party blocker thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=1 owner=0 timeout=5000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=0 owner=1 timeout=500000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating third party blocker thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=1 owner=0 timeout=500000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=1 locked=1 owner=0 timeout=2000000000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR >futex_requeue_pi: Test requeue functionality > Arguments: broadcast=0 locked=1 owner=0 timeout=2000000000ns > ERROR: Operation not permitted: pthread_create > ERROR: Creating waiting thread failed >Result: ERROR > >futex_requeue_pi_mismatched_ops: Detect mismatched requeue_pi operations >Result: PASS > >futex_requeue_pi_signal_restart: Test signal handling during requeue_pi > Arguments: > ERROR: Operation not permitted: pthread_create > ERROR: Unknown error -1: Creating waiting thread failedResult: ERROR > >futex_wait_timeout: Block on a futex and wait for timeout > Arguments: timeout=100000ns >Result: PASS > >futex_wait_wouldblock: Test the unexpected futex value in FUTEX_WAIT >Result: PASS > >futex_wait_uninitialized_heap: Test the uninitialized futex value in >FUTEX_WAIT >Result: PASS >futex_wait_private_mapped_file: Test the futex value of private file >mappings in FUTEX_WAIT >Result: PASS > > >-- >Shuah Khan >Sr. Linux Kernel Developer >Open Source Innovation Group >Samsung Research America (Silicon Valley) >shuahkh@osg.samsung.com | (970) 217-8978 > -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/