Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965498AbbENAtl (ORCPT ); Wed, 13 May 2015 20:49:41 -0400 Received: from mail-by2on0136.outbound.protection.outlook.com ([207.46.100.136]:10798 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965310AbbENAtg (ORCPT ); Wed, 13 May 2015 20:49:36 -0400 Authentication-Results: c-s.fr; dkim=none (message not signed) header.d=none; Message-ID: <1431564565.3868.157.camel@freescale.com> Subject: Re: [PATCH 1/4] Partially revert "powerpc: Remove duplicate cacheable_memcpy/memzero functions" From: Scott Wood To: Christophe Leroy CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , , , "Joakim Tjernlund" , Kyle Moffett Date: Wed, 13 May 2015 19:49:25 -0500 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:2:5800:3f7:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BLUPR02CA055.namprd02.prod.outlook.com (25.160.23.173) To BY1PR03MB1481.namprd03.prod.outlook.com (25.162.210.14) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;2:gQoOZNOZfN1ZOWRsEMHstG++UhtlQuN8eM4bPtLGJR1EK+YHcnIjsjFM2hh9RmVM;2:q5Rlcc9GHnLA1h+U2vI64k4hL8v04nZySEOhOzP/fTFTs5hNBYMkpF7BDGI/ysItoTzknaTyaGGWXhIMFnieSd40g6LTITdHVzsHpXf9unVLaI+86feLtzSTN5pI9JUxNqaQqFqZyn6qBlx7OdNytw==;6:idNtoQinaQqqMmSSp8etRsDkm7QBv1RdJcsvozdYeMQ+0ODc9L5wR6KkxQnvccRYygle409yfgKE5Iq49/LH03gjwDK2BtY8q7L1kyhpitvfiZJ/tABpqi75h0rOJjk8lnwxOSEicIhje98YfKgDixGFOIqMK3buJ3W28lsjVTHdJ+bSQl+DoRdFcdoknTiFcLe6hbSFw7A2AHMFUuGu6rSSfAVt+Mh7XjMz3As/dSuqZcqQkgqagjebfH+bP5jB/acTb5Uku1YM/Cg3U9/ei7PppB/0YWyHTaOnkYns9tQjseOsdjDg6V6jlaG2UBgxPKBfSKCnVFJUXFjSzWSECxBH2VeuLAYBNjYqG5CD9hyejR3u+ROnega+WQbk7bFznuk2N8vNKt5bVLX+chVBmGA5VPfH3ygimNbX41hs1HxrZbPrQY/sZpK+MVhq/dp47rTrvSdJz5J/VUxKI1e8Dk2IfyouaXDHfnTqK32S5eTwANfi7oAIWMNpSHdavnLd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1481; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY1PR03MB1481;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1481; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;3:/c9oLHjtN88Gtg6+F+HZFQJqcTkPV9+TptSjv/IpF3rGwD8ROx2JpwtsHO/YJE3Re26R/ufie6rh67TtUbIKEC5sqg6kI1cEjBnS9mkY/99dJjmKk2Oi+zI/McJayLGQU1eQbEgPcRILceRApBBpwvjq5z4DlIx0NZ910fheT1CctBeldDNcyYPl2bxq6Kd/BHzT3I1HQx2JoW+13a5J7RK2d/iGfWgH8pYpRp0wPKljw4EzshH+GqADfVeRRsDYMzY6Auat4gVFj2Xdu/C6/shl5DE7V7j+xWAClYUm1Ik= X-Forefront-PRVS: 0576145E86 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(24454002)(23676002)(2950100001)(77096005)(62966003)(77156002)(40100003)(110136002)(33646002)(50466002)(122386002)(5001960100002)(36756003)(92566002)(189998001)(87976001)(50226001)(5820100001)(50986999)(76176999)(47776003)(86362001)(46102003)(42186005)(103116003)(7059030)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1481;H:[IPv6:2601:2:5800:3f7:12bf:48ff:fe84:c9a0];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;9:SkoAM2V8O5bEPE8AeT3ZgAbp9DtqxsbT/x1aF+6sGW8XRl2nXKdZMD3HURN2zSuR23DOx6x/jyKY3Notpt37LZsfXbgV+FX/ORyChECgdHmRwoJXOS82Q6AO7Jqv1A0501R8J9XmHGqxy9Tm/fIjf/tNGojqDgs8c8BQcpYhXmuXC1m2qErEiSwYCDZXY0/6FoIbdsDztkXplnOVrGrLIrAuGRUhftUjQiKG+vS33aoYoFA9k/ir60MpzoJiv+TnUJq3xOjpKsvUE7TfgxlfMA6OVPRZw/qEWduFcO5ov5TG1mENGomxcNYHnxt1v1xQ9CkUV4siQAHZrrGtdwE1GlQTuB6wSj53p39nDqBBkUVotOMAm8iEC1Fn/FS/ojgaJ95LtZRzcbxzS884lV0G5su+4jxoiFjVAOlgsgx6HtNLBAfZPUuSBzZMWy/z4ZXMKF8SFWXpkIFBTcz04ZpKiXMCovmOPsTxKyErjEcetXcdLuZgtFNPwVB+fyDHJWqXXHYHPybEElneWgaTDn+NHNKzR8SX+mv0137q0Z1egSIPekki86sNfvAgRtJU//ZYSD2LdAkNAGo0UHG1PnndbGxW612FMnM/WkikjOypcLFe6GuDvLNnEL031pDC50l6a0Rfvul1BRrYV73/MyVRJBS2bTfW+IXLZUNosxbDwicFmsvOh5BZzgbBVXEtv0ZOKK5UrdcQTKVpAJJJG3+JArIet9UKScOpk430YV7+Y1LZp0+ZQwnIDCBtqocK+8NJtY+8kR4q2sgtI4WaeNxogSJfVWE7AzVlEMbaIG1t/dM=;3:VN0OuRXP2671zUbXmn5Orx3p/Tc6O9FLi0OMklcvsJHC5+JFe07w/fJgRCzSN0EkWSGeD+IHBuFb6imtLgpCa5y8QCYX9zo+ue/cDns7+to0MAU+nZsnu9luLPzM9sfybeKJQQ+solISAl6IJMesiA== X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;10:khZvIKXRNFEZmSQQaQqrKZB60tHT2FO2bl0aZcBqus6elcyBEFmpYg+F5ziraj9wUp0BeCaVNA6nK65L4Ym6O6OXpEXGrvFHCsP48FLirfA=;6:RCyFjfZim2yQK6VgLalEbE8f1Ozbuza199Wvn/XQ0yKAhXT7nzxToEBXHzN1TsbW X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2015 00:49:32.6981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1481 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 901 Lines: 24 On Tue, 2015-05-12 at 15:32 +0200, Christophe Leroy wrote: > This partially reverts > commit 'powerpc: Remove duplicate cacheable_memcpy/memzero functions > ("f909a35bdfb7cb350d078a2cf888162eeb20381c")' I don't have that SHA. Do you mean b05ae4ee602b7dc90771408ccf0972e1b3801a35? > Functions cacheable_memcpy/memzero are more efficient than > memcpy/memset as they use the dcbz instruction which avoids refill > of the cacheline with the data that we will overwrite. I don't see anything in this patchset that addresses the "NOTE: The old routines are just flat buggy on kernels that support hardware with different cacheline sizes" comment. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/