Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754365AbbENBpn (ORCPT ); Wed, 13 May 2015 21:45:43 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:46660 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbbENBpk (ORCPT ); Wed, 13 May 2015 21:45:40 -0400 Date: Wed, 13 May 2015 20:43:20 -0500 From: Felipe Balbi To: Kevin Hilman CC: Alexander Duyck , , , , , , , Subject: Re: [net-next PATCH] net: Reserve skb headroom and set skb->dev even if using __alloc_skb Message-ID: <20150514014320.GA20006@saruman.tx.rr.com> Reply-To: References: <20150513182738.GA28201@saruman.tx.rr.com> <20150513203413.8252.98057.stgit@ahduyck-vm-fedora22> <7h8ucs6tzc.fsf@deeprootsystems.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg" Content-Disposition: inline In-Reply-To: <7h8ucs6tzc.fsf@deeprootsystems.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2352 Lines: 63 --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 13, 2015 at 02:35:51PM -0700, Kevin Hilman wrote: > Alexander Duyck writes: >=20 > > When I had inlined __alloc_rx_skb into __netdev_alloc_skb and > > __napi_alloc_skb I had overlooked the fact that there was a return in t= he > > __alloc_rx_skb. As a result we weren't reserving headroom or setting t= he > > skb->dev in certain cases. This change corrects that by adding a coupl= e of > > jump labels to jump to depending on __alloc_skb either succeeding or fa= iling. > > > > Fixes: 9451980a6646 ("net: Use cached copy of pfmemalloc to avoid acces= sing page") > > Reported-by: Felipe Balbi > > Signed-off-by: Alexander Duyck >=20 > Tested this on top of next-20150513 on an ARM/OMAP > (am335x-boneblack.dts) an it fixes the boot problem for me. >=20 > Tested-by: Kevin Hilman Yeah, I know it's too late, but I also tested on my AM437x SK. Tested-by: Felipe Balbi --=20 balbi --gKMricLos+KVdGMg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVU/24AAoJEIaOsuA1yqREyq8P/3WlkGcKeWdhNASUDUkXm0vL A2WWN5/aiG8V4UXa4oTEcSfE0M3Ugt8Pxn4bjKEfMYvi6b85ik2fSB+i2UBEj3+i 6BmSveeESRehncfLCymelrE8FCnBdX5hHGNEpBWsfDq5M6Si6il1AUyiEldtVA9y +GmeTPOe4UpIfqdtclg0dDoNjJZkbeI/uGUt9gYMsddpBAo6Y49qV2KCy5YO+SM0 OMEIMYrdEdk2aVuY8grmvmvUYCbxur1OYvlUYD5oMf9/SuaB0fXnnH6kUYYkEnP1 lmP2mqNsOD5fwLW6/94/gbS34bSwkKjm1QKBMxerNpTLsVqUq5LOf+bB9DhfioFg 347wUgGiuvB5cejVJuI9WdeM29DzgPH/8sGQweKpSAG+A8Cdbm4OXLU+eSU6XX+T LQ5z3RtkAHgDX87EVLj76Da+IVraqZWY0gg4jsKuBSOqOTRWCF83LZV3Dvp9P7// qQ0Ki/GmwQzrwvEafFDIBZUhskY0RJHZdcFyTCD0mRXKw7uRVS9WkfejJy/UitlQ gf6afnMt0m9IKBXscJXye5DYZqeuptRbF/wfBQt8cDLiUVVhho5UgmASVqfQc4cw ZJRWrTr7GXjGdUMf6ogyb2OgroGVQa5cGaYgCChX+9UxXPHGCvKjKA96Gf6PYmup uG+f3rWXoczo8j4bqhMr =v4wa -----END PGP SIGNATURE----- --gKMricLos+KVdGMg-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/