Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934516AbbENC0y (ORCPT ); Wed, 13 May 2015 22:26:54 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:57655 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933504AbbENC0w (ORCPT ); Wed, 13 May 2015 22:26:52 -0400 X-Greylist: delayed 46752 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 May 2015 22:26:51 EDT X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: dgreid@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: <3a67f99f46864762aabe9b048f405660> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <555406DA.8040709@rock-chips.com> Date: Thu, 14 May 2015 10:22:18 +0800 From: zhengxing User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Dylan Reid CC: Mark Brown , Xing Zheng , Douglas Anderson , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Sonny Rao , linux-rockchip@lists.infradead.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver References: <1431422797-31903-1-git-send-email-zhengxing@rock-chips.com> <1431422797-31903-2-git-send-email-zhengxing@rock-chips.com> <20150512192215.GZ3066@sirena.org.uk> <55535035.5070608@rock-chips.com> <20150513164250.GB2761@sirena.org.uk> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2165 Lines: 45 On 2015年05月14日 07:11, Dylan Reid wrote: > On Wed, May 13, 2015 at 10:21 AM, Dylan Reid wrote: >> On Wed, May 13, 2015 at 9:42 AM, Mark Brown wrote: >>> On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: >>>> On 2015年05月13日 03:22, Mark Brown wrote: >>>>> Is it not possible to extend simple card to handle your use cases? >>>>> Given the very generic naming and the fact that things like jack >>>>> detection and so on should depend on the CODEC and board usually rather >>>>> than on the SoC it doesn't sound like this is Rockchip specific. >>>>> This also looks like you're reimplementing some device model enumeration >>>>> stuff which probably shouldn't be happening but let's understand the >>>>> problem you're trying to solve here before going too far into the code. >>>> Because we are trying to bring rt5650 in the project, so we intend to >>>> describe supported codecs with DTS via only a rockchip machine driver file, >>>> others remain pre-implement(like max98090 / rt5645 that vendor machine >>>> driver). >>> I don't undertand what you're saying here, sorry - why is this not just >>> a case of writing multiple machine drivers? >> I don't understand this either. I'd think the best solution is >> simple-card, configured through DTS for each device. Hi Mark, Dylan, I tried to use simple-card and had some trouble that jack detection. So my idea is simply: /-- rockchip_max98090 (to configure max98090, and no need to via DTS) rockchip_machine_driver |-- rockchip_rt5645 (to configure rt5650/rt5645, and no need to via DTS) (supported codecs via DTS) \-- rockchip_(maybe other codecs) It is right that it is base on original rockchip_max98090, but the old rockchip_max98090 used DTS. I tried to explain my ideas. Your kind suggestions will be highly appreciated. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/