Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753330AbbENHUt (ORCPT ); Thu, 14 May 2015 03:20:49 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:16599 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbbENHUq (ORCPT ); Thu, 14 May 2015 03:20:46 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 14 May 2015 00:18:17 -0700 Message-ID: <55544CC5.9050001@nvidia.com> Date: Thu, 14 May 2015 08:20:37 +0100 From: Jon Hunter User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Lee Jones , Andrew Bresticker CC: Stephen Warren , Thierry Reding , Alexandre Courbot , , , , , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Samuel Ortiz" Subject: Re: [PATCH v8 4/9] mfd: Add binding document for NVIDIA Tegra XUSB References: <1430761002-9327-1-git-send-email-abrestic@chromium.org> <1430761002-9327-5-git-send-email-abrestic@chromium.org> <20150513143954.GA3394@x1> In-Reply-To: <20150513143954.GA3394@x1> X-NVConfidentiality: public X-Originating-IP: [10.21.134.107] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3168 Lines: 91 Hi Lee, On 13/05/15 15:39, Lee Jones wrote: > On Mon, 04 May 2015, Andrew Bresticker wrote: > >> Add a binding document for the XUSB host complex on NVIDIA Tegra124 >> and later SoCs. The XUSB host complex includes a mailbox for >> communication with the XUSB micro-controller and an xHCI host-controller. >> >> Signed-off-by: Andrew Bresticker >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Ian Campbell >> Cc: Kumar Gala >> Cc: Samuel Ortiz >> Cc: Lee Jones >> --- >> Changes from v7: >> - Move non-shared resources into child nodes. >> New for v7. >> --- >> .../bindings/mfd/nvidia,tegra124-xusb.txt | 37 ++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/nvidia,tegra124-xusb.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/nvidia,tegra124-xusb.txt b/Documentation/devicetree/bindings/mfd/nvidia,tegra124-xusb.txt >> new file mode 100644 >> index 0000000..bc50110 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/nvidia,tegra124-xusb.txt >> @@ -0,0 +1,37 @@ >> +NVIDIA Tegra XUSB host copmlex >> +============================== >> + >> +The XUSB host complex on Tegra124 and later SoCs contains an xHCI host >> +controller and a mailbox for communication with the XUSB micro-controller. >> + >> +Required properties: >> +-------------------- >> + - compatible: For Tegra124, must contain "nvidia,tegra124-xusb". >> + Otherwise, must contain '"nvidia,-xusb", "nvidia,tegra124-xusb"' >> + where is tegra132. >> + - reg: Must contain the base and length of the XUSB FPCI registers. >> + - ranges: Bus address mapping for the XUSB block. Can be empty since the >> + mapping is 1:1. >> + - #address-cells: Must be 2. >> + - #size-cells: Must be 2. >> + >> +Example: >> +-------- >> + usb@0,70098000 { >> + compatible = "nvidia,tegra124-xusb"; >> + reg = <0x0 0x70098000 0x0 0x1000>; >> + ranges; >> + >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + usb-host@0,70090000 { >> + compatible = "nvidia,tegra124-xhci"; >> + ... >> + }; >> + >> + mailbox { >> + compatible = "nvidia,tegra124-xusb-mbox"; >> + ... >> + }; > > This doesn't appear to be a proper MFD. I would have the USB and > Mailbox devices probe seperately and use a phandle to point the USB > device to its Mailbox. > > usb@xyz { > mboxes = <&xusb-mailbox, [chan]>; > }; > I am assuming that Andrew had laid it out like this to reflect the hw structure. The mailbox and xhci controller are part of the xusb sub-system and hence appear as child nodes. My understanding is that for device-tree we want the device-tree structure to reflect the actual hw. Is this not the case? Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/