Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932443AbbENID3 (ORCPT ); Thu, 14 May 2015 04:03:29 -0400 Received: from mx3.wp.pl ([212.77.101.9]:31443 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328AbbENID0 convert rfc822-to-8bit (ORCPT ); Thu, 14 May 2015 04:03:26 -0400 Date: Thu, 14 May 2015 10:03:16 +0200 From: Jakub =?UTF-8?B?S2ljacWEc2tp?= To: ram kiran Cc: "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jslaby@suse.cz" , "gregkh@linuxfoundation.org" , "indrakanti.ram@gmail.com" Subject: Re: [PATCH v2] sc16is7xx: spi interface is added Message-ID: <20150514100316.75e23c2f@north> In-Reply-To: References: <20150513142112.32fb6781@north> X-Mailer: Claws Mail 3.11.1-85-ga87522 (GTK+ 2.24.27; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-WP-AV: skaner antywirusowy poczty Wirtualnej Polski S. A. X-WP-SPAM: NO 0000000 [MdPU] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2729 Lines: 73 On Thu, 14 May 2015 13:16:20 +0530, ram kiran wrote: > > On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: > >> spi interface for sc16is7xx is added along with Kconfig flag > >> to enable spi or i2c, thus in a instance we can have either > >> spi or i2c or both, in sync to the hw. > >> > >> Signed-off-by: ram.i hcltech > >> --- > >> > >> Changes in v2: > >> -Added seprate flags for i2c and spi > >> -Added space in the comments lines > >> -Added MODULE_ALIAS for spi interface > >> --- > >> drivers/tty/serial/Kconfig | 27 +++++++++++++++-- > >> drivers/tty/serial/sc16is7xx.c | 69 +++++++++++++++++++++++++++++++++++++++++- > >> 2 files changed, 92 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > >> index f8120c1..8c505b2 100644 > >> --- a/drivers/tty/serial/Kconfig > >> +++ b/drivers/tty/serial/Kconfig > >> @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE > >> > To avoid error or warning on build, i think this would be the probable solution. > I thinking to go with this, any comments on this please. > > config SERIAL_SC16IS7XX >     bool > > config SERIAL_SC16IS7XX_SELECT >     tristate "SC16IS7xx serial support" >     select SERIAL_CORE >     depends on I2C || SPI_MASTER >     select REGMAP_I2C if I2C >     select REGMAP_SPI if SPI_MASTER >     help >       This selects support for SC16IS7xx serial ports. >       Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, >       SC16IS760 and SC16IS762. Select supported buses using options below. > > config SERIAL_SC16IS7XX_I2C >     bool "SC16IS7xx for I2C interface" >     depends on SERIAL_SC16IS7XX_SELECT >     select SERIAL_SC16IS7XX >     default y >     help >       Enable SC16IS7xx driver on I2C bus. > > config SERIAL_SC16IS7XX_SPI >     bool "SC16IS7xx for spi interface" >     depends on SERIAL_SC16IS7XX_SELECT >     select SERIAL_SC16IS7XX >     help >       Enable SC16IS7xx driver on SPI bus. > This looks quite elegant! Should we aslo make SERIAL_SC16IS7XX depend on SERIAL_SC16IS7XX_I2C || SERIAL_SC16IS7XX_SPI? Would that work? I know little about kbuild but I'm worried that someone doing oldconfig can still get SERIAL_SC16IS7XX selected while saying no to all the others. Other option would be to swap the names between SERIAL_SC16IS7XX and SERIAL_SC16IS7XX_SELECT, oldconfig would run smoother. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/