Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932612AbbENIn4 (ORCPT ); Thu, 14 May 2015 04:43:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46943 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392AbbENInx (ORCPT ); Thu, 14 May 2015 04:43:53 -0400 Message-ID: <5554603F.8020306@redhat.com> Date: Thu, 14 May 2015 10:43:43 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Wanpeng Li CC: Xiao Guangrong , gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 09/10] KVM: MMU: fix MTRR update References: <1431499348-25188-1-git-send-email-guangrong.xiao@linux.intel.com> <1431499348-25188-10-git-send-email-guangrong.xiao@linux.intel.com> <20150513084341.GA4910@kernel> <55535B40.2060504@redhat.com> <20150514001648.GA5206@kernel> In-Reply-To: <20150514001648.GA5206@kernel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 715 Lines: 19 On 14/05/2015 02:16, Wanpeng Li wrote: > >SPTEs are kept around and cached. The "role" field is used as the hash > >key; if the role doesn't change, SPTEs are reused, so you have to zap > >the SPTEs explicitly. > > Btw, why the patch changelog mentioned that the root shadow page will be > reused, I think it will be zapped in mmu_free_roots. Who has set sp->role.invalid on it? If no one has, it's not zapped and it will be found again in the hash table. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/