Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932859AbbENJuO (ORCPT ); Thu, 14 May 2015 05:50:14 -0400 Received: from mail.skyhub.de ([78.46.96.112]:54208 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932561AbbENJuM (ORCPT ); Thu, 14 May 2015 05:50:12 -0400 Date: Thu, 14 May 2015 11:50:06 +0200 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86, mce, amd: Read mcgstatus before we log the error Message-ID: <20150514095006.GB29125@pd.tnic> References: <1431538624-19565-1-git-send-email-Aravind.Gopalakrishnan@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1431538624-19565-1-git-send-email-Aravind.Gopalakrishnan@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 38 On Wed, May 13, 2015 at 12:37:04PM -0500, Aravind Gopalakrishnan wrote: > Code to read mcgstatus was introduced with patch 44612a3ac. > However, that seems to have been accidentally removed in a3a529d10. > Adding that back here. > > Signed-off-by: Aravind Gopalakrishnan > --- > arch/x86/kernel/cpu/mcheck/mce_amd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c > index e99b150..7edfa4c 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c > +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c > @@ -319,6 +319,7 @@ static void __log_error(unsigned int bank, bool threshold_err, u64 misc) > return; > > mce_setup(&m); > + rdmsrl(MSR_IA32_MCG_STATUS, m.mcgstatus); Any meaningful bits in that MSR we wanna know when getting a thresholding or deferred error? Are they even defined? If yes, RIPV should always be 1b, EIPV too, MCIP can't be set. -ENOMOREUSEFULBITS. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/