Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933145AbbENKcm (ORCPT ); Thu, 14 May 2015 06:32:42 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:35168 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932570AbbENKcj (ORCPT ); Thu, 14 May 2015 06:32:39 -0400 MIME-Version: 1.0 In-Reply-To: References: <1426676484-21812-1-git-send-email-marc.zyngier@arm.com> <1426676484-21812-3-git-send-email-marc.zyngier@arm.com> Date: Thu, 14 May 2015 12:32:38 +0200 Message-ID: Subject: Re: [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state From: Linus Walleij To: Feng Kan Cc: Marc Zyngier , Abhijeet Dharmapurikar , Stephen Boyd , Phong Vo , Tin Huynh , Y Vo , Thomas Gleixner , Toan Le , Bjorn Andersson , Jason Cooper , Arnd Bergmann , linux-arm-msm , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , Alexandre Courbot Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 32 On Wed, May 13, 2015 at 5:44 PM, Feng Kan wrote: > We are using the gpio driver with gpio_key for power button. The gpio > status can only be retrieved from the GIC register when the gpio is > acting as a interrupt. OK I understand so much. SPISR is a status register of the state of the IRQ lines of shared peripherals. But surely the GPIO block has its own status register, so are you saying that this register is unreliable? I can think of a few reasons, like transient IRQs etc but what is actually causing this? Techically the GIC would normally be higher up the food chain, i.e. one IRQ on the GIC is cascaded to sub-IRQs on the GPIO chip by virtue of its own struct irq_chip and irqdomain. The exception is typically only systems where the GPIO block is fused with the IRQ controller so that each GPIO line has its own unique IRQ line on the primary, top-level interrupt controller. Which GPIO driver is this? Is it upstream? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/