Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932993AbbENKl3 (ORCPT ); Thu, 14 May 2015 06:41:29 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:37447 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932828AbbENKl0 (ORCPT ); Thu, 14 May 2015 06:41:26 -0400 MIME-Version: 1.0 In-Reply-To: <1430326898-2992-1-git-send-email-fabf@skynet.be> References: <1430326898-2992-1-git-send-email-fabf@skynet.be> Date: Thu, 14 May 2015 13:41:25 +0300 Message-ID: Subject: Re: [PATCH 1/1 linux-next] configfs: unexport/make static config_item_init() From: Daniel Baluta To: Fabian Frederick Cc: Linux Kernel Mailing List , Andrew Morton , Joel Becker Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2015 Lines: 54 On Wed, Apr 29, 2015 at 8:01 PM, Fabian Frederick wrote: > config_item_init() is only used in item.c > > Signed-off-by: Fabian Frederick Nack! Have a look at drivers/usb/gadget/configfs.c > --- > fs/configfs/item.c | 3 +-- > include/linux/configfs.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/configfs/item.c b/fs/configfs/item.c > index e65f9ff..4d6a30e 100644 > --- a/fs/configfs/item.c > +++ b/fs/configfs/item.c > @@ -47,12 +47,11 @@ static void config_item_release(struct kref *kref); > * config_item_init - initialize item. > * @item: item in question. > */ > -void config_item_init(struct config_item *item) > +static void config_item_init(struct config_item *item) > { > kref_init(&item->ci_kref); > INIT_LIST_HEAD(&item->ci_entry); > } > -EXPORT_SYMBOL(config_item_init); > > /** > * config_item_set_name - Set the name of an item > diff --git a/include/linux/configfs.h b/include/linux/configfs.h > index 34025df..c9e5c57 100644 > --- a/include/linux/configfs.h > +++ b/include/linux/configfs.h > @@ -71,7 +71,6 @@ static inline char *config_item_name(struct config_item * item) > return item->ci_name; > } > > -extern void config_item_init(struct config_item *); > extern void config_item_init_type_name(struct config_item *item, > const char *name, > struct config_item_type *type); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/