Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933268AbbENKvb (ORCPT ); Thu, 14 May 2015 06:51:31 -0400 Received: from mail.us.es ([193.147.175.20]:36349 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932679AbbENKv0 (ORCPT ); Thu, 14 May 2015 06:51:26 -0400 X-Qmail-Scanner-Diagnostics: from 127.0.0.1 by antivirus5 (envelope-from , uid 501) with qmail-scanner-2.10 (clamdscan: 0.98.7/20456. spamassassin: 3.4.0. Clear:RC:1(127.0.0.1):SA:0(-103.2/7.5):. Processed in 4.979972 secs); 14 May 2015 10:51:23 -0000 X-Spam-ASN: AS12715 87.216.0.0/16 X-Envelope-From: pneira@us.es Date: Thu, 14 May 2015 12:56:05 +0200 From: Pablo Neira Ayuso To: Denys Vlasenko Cc: "David S. Miller" , Jozsef Kadlecsik , "Eric W. Biederman" , Jan Engelhardt , Jiri Pirko , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH] netfilter: ipset: deinline ip_set_put_extensions() Message-ID: <20150514105605.GA4852@salvia> References: <1430922537-28428-1-git-send-email-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430922537-28428-1-git-send-email-dvlasenk@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 21 On Wed, May 06, 2015 at 04:28:57PM +0200, Denys Vlasenko wrote: > On x86 allyesconfig build: > The function compiles to 489 bytes of machine code. > It has 25 callsites. > > text data bss dec hex filename > 82441375 22255384 20627456 125324215 7784bb7 vmlinux.before > 82434909 22255384 20627456 125317749 7783275 vmlinux Jozsef, I'm going to applied this patch to nf-next. I think that things like ip_set_put_skbinfo() can be also deinlined and move to the core as exported symbol as this run from the control plane path (ie. netlink). Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/