Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932775AbbENLbY (ORCPT ); Thu, 14 May 2015 07:31:24 -0400 Received: from kdh-gw.itdev.co.uk ([89.21.227.133]:34933 "EHLO hermes.kdh.itdev.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932498AbbENLbW (ORCPT ); Thu, 14 May 2015 07:31:22 -0400 Message-ID: <55548784.3080505@itdev.co.uk> Date: Thu, 14 May 2015 12:31:16 +0100 From: Nick Dyer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Pan Xinhui , linux-kernel@vger.kernel.org CC: dmitry.torokhov@gmail.com, yanmin_zhang@linux.intel.com, mnipxh@163.com Subject: Re: [PATCH V2] atmel: fix a race between fw_load and data free References: <5555D639.90405@intel.com> In-Reply-To: <5555D639.90405@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 627 Lines: 23 Hi- This looks like a good tidy up, one minor comment: On 15/05/15 12:19, Pan Xinhui wrote: > + mxt_wait_for_completion(data, &data->fw_load_completion, > + MXT_FW_RESET_TIME); this should probably just be wait_for_completion(&data->fw_load_completion); rather than timing out (the MXT_FW_RESET_TIME may not be an appropriate length anyway) cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/