Date: Thu, 14 May 2015 15:31:05 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: hekuang <hekuang@zoho.com>, acme@kernel.org, jolsa@kernel.org,
        mingo@redhat.com, a.p.zijlstra@chello.nl, wangnan0@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used
 by traceevent plugins
Message-ID: <20150514133105.GC1313@krava.redhat.com>
References: <1431412917-101336-1-git-send-email-hekuang@huawei.com>
 <20150512123744.GF22341@krava.redhat.com>
 <55521B79.60202@zoho.com>
 <20150513145049.GF25652@krava.redhat.com>
 <55549B6F.3030701@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55549B6F.3030701@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1064
Lines: 35

On Thu, May 14, 2015 at 08:56:15PM +0800, He Kuang wrote:

SNIP

> >>It seems new targets are needed. In the v2 patch,
> >
> >hum, I dont get it.. why ?
> >
> >dynamic-list-file gets rebuilt any time plugins are rebuilt..
> >why not keep just the 'plugins' dependency?
> 
> You can test your patch as following steps:
> 
> $ touch ../lib/traceevent/plugin_function.c
> $ make
>   CC       plugin_function.o
>   LD       plugin_function-in.o
>   LINK     plugin_function.so
>   GEN      libtraceevent-dynamic-list
> 
> perf is not rebuilt. There should be a 'GEN perf', right?

hum, right.. so this is separated bug that was there even
without your change. I tried to kick my change to address
that and ended up with what you sent in v2 ;-)

I have another comment for your v2, which I'll send right away

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/