Date: Thu, 14 May 2015 15:33:36 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com,
        a.p.zijlstra@chello.nl, wangnan0@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used
 by traceevent plugins
Message-ID: <20150514133336.GA24795@krava.redhat.com>
References: <1431412917-101336-1-git-send-email-hekuang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431412917-101336-1-git-send-email-hekuang@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1223
Lines: 36

On Tue, May 12, 2015 at 06:41:56AM +0000, He Kuang wrote:

SNIP

> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 03409cc..338c426 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -172,6 +172,7 @@ endif
>  
>  LIBTRACEEVENT = $(TE_PATH)libtraceevent.a
>  export LIBTRACEEVENT
> +LIBTRACEEVENT_DYNAMIC_LIST = $(TE_PATH)libtraceevent-dynamic-list
>  
>  LIBAPI = $(LIB_PATH)libapi.a
>  export LIBAPI
> @@ -278,8 +279,9 @@ build := -f $(srctree)/tools/build/Makefile.build dir=. obj
>  $(PERF_IN): $(OUTPUT)PERF-VERSION-FILE $(OUTPUT)common-cmds.h FORCE
>  	$(Q)$(MAKE) $(build)=perf
>  
> -$(OUTPUT)perf: $(PERFLIBS) $(PERF_IN)
> -	$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $(PERF_IN) $(LIBS) -o $@
> +LD_LIBTRACEEVENT_FLAGS += -Xlinker --dynamic-list=$(LIBTRACEEVENT_DYNAMIC_LIST)

Could you please just update LDFLAGS directly? I dont think
there's a need for separated variable..

otherwise it seems ok to me

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/