Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933529AbbENN6I (ORCPT ); Thu, 14 May 2015 09:58:08 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35109 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbbENN6F (ORCPT ); Thu, 14 May 2015 09:58:05 -0400 Date: Thu, 14 May 2015 15:57:45 +0200 From: AdrianRemonda To: Greg Kroah-Hartman Cc: Ian Abbott , H Hartley Sweeten , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH] Staging: comedi: Removed expression that has no effect Message-ID: <20150514135745.GA2608@debian.home> References: <1431464634-25240-1-git-send-email-adrianremonda@gmail.com> <20150512211901.GA10352@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150512211901.GA10352@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 24 On Tue, May 12, 2015 at 02:19:01PM -0700, Greg Kroah-Hartman wrote: > On Tue, May 12, 2015 at 11:03:52PM +0200, Adrian Remonda wrote: > > This patch remove a register from an '|' expression. > > It is wrong since after in the code, the variable ai_trig gets > > written back to that register. > > > > > > modified: drivers/staging/comedi/drivers/ni_mio_common.c > > What does this line mean here? > > And Hartley sent a fix for this yesterday, I haven't had a chance to > apply it yet... > > thanks, > > greg k-h Sorry I did't see that there was a previous fix. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/