Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161080AbbENOIW (ORCPT ); Thu, 14 May 2015 10:08:22 -0400 Received: from smarthost01b.mail.zen.net.uk ([212.23.1.3]:35853 "EHLO smarthost01b.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933583AbbENOHi (ORCPT ); Thu, 14 May 2015 10:07:38 -0400 Message-ID: <1431612451.2881.54.camel@linaro.org> Subject: Re: [PATCH 5/5] arm64: Add DT support for Juno r1 board. From: "Jon Medhurst (Tixy)" To: Liviu Dudau Cc: Arnd Bergmann , Olof Johansson , Rob Herring , Mark Rutland , Ian Campbell , Marc Zyngier , Catalin Marinas , Will Deacon , Sudeep Holla , devicetree , LAKML , LKML Date: Thu, 14 May 2015 15:07:31 +0100 In-Reply-To: <1431537092-19597-6-git-send-email-Liviu.Dudau@arm.com> References: <1431537092-19597-1-git-send-email-Liviu.Dudau@arm.com> <1431537092-19597-6-git-send-email-Liviu.Dudau@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-smarthost01b-IP: [82.69.122.217] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2392 Lines: 65 On Wed, 2015-05-13 at 18:11 +0100, Liviu Dudau wrote: > This board is based on Juno r0 with updated Cortex A5x revisions > and board errata fixes. It also contains coherent ThinLinks ports > on the expansion slot that allow for an AXI master on the daughter > card to participate in a coherency domain. > > Support for SoC PCIe host bridge will be added as a separate series. > > Signed-off-by: Liviu Dudau > --- > arch/arm64/boot/dts/arm/Makefile | 2 +- > arch/arm64/boot/dts/arm/juno-r1.dts | 123 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 124 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/arm/juno-r1.dts > > diff --git a/arch/arm64/boot/dts/arm/Makefile b/arch/arm64/boot/dts/arm/Makefile > index 301a0da..c5c98b9 100644 > --- a/arch/arm64/boot/dts/arm/Makefile > +++ b/arch/arm64/boot/dts/arm/Makefile > @@ -1,5 +1,5 @@ > dtb-$(CONFIG_ARCH_VEXPRESS) += foundation-v8.dtb > -dtb-$(CONFIG_ARCH_VEXPRESS) += juno.dtb > +dtb-$(CONFIG_ARCH_VEXPRESS) += juno.dtb juno-r1.dtb > dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb > > always := $(dtb-y) > diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts > new file mode 100644 > index 0000000..f6bc073 > --- /dev/null > +++ b/arch/arm64/boot/dts/arm/juno-r1.dts > @@ -0,0 +1,123 @@ > +/* > + * ARM Ltd. Juno Platform > + * > + * Copyright (c) 2015 ARM Ltd. > + * > + * This file is licensed under a dual GPLv2 or BSD license. > + */ > + > +/dts-v1/; > + > +#include > + > +/ { > + model = "ARM Juno development board (r1)"; > + compatible = "arm,juno", "arm,vexpress"; Is there scope for adding "arm,juno-r1" to the front of that list? Reason I ask, is that I can't help but think [1] that userside code (like Android) which wants to select device-specific configuration, should use something like the devices compatible string rather than what they currently propose [2]. [1] https://lists.linaro.org/pipermail/linaro-android/2015-April/002743.html [2] https://lists.linaro.org/pipermail/linaro-android/2015-April/002742.html -- Tixy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/