Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753440AbbENO4W (ORCPT ); Thu, 14 May 2015 10:56:22 -0400 Received: from mail-bn1on0141.outbound.protection.outlook.com ([157.56.110.141]:38240 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753058AbbENO4N (ORCPT ); Thu, 14 May 2015 10:56:13 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NOCHHK-07-4GV-02 X-M-MSG: Message-ID: <5554B787.4020400@amd.com> Date: Thu, 14 May 2015 09:56:07 -0500 From: Aravind Gopalakrishnan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Borislav Petkov CC: , , , , , , Subject: Re: [PATCH] x86, mce, amd: Read mcgstatus before we log the error References: <1431538624-19565-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <20150514095006.GB29125@pd.tnic> In-Reply-To: <20150514095006.GB29125@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD033;1:PHr3hoE2PcEE3keFB2xUAxTUlaFryM+PNVGW2zWBXx/EaEozJ9J5RMhFhyQ51vpZ60HhdncOgPVX6ugUG3GxmFZQNxmo2RguDNjUdx1lhx4N3sZCYGz1jMa7TVmlndJJs2JmMz53wSaT0FZbJJGRKB+gc8FeVToqSVjWLTaO6tg2Ril+8ZVf+m+7E4fCj33B6jgUguNjKVXdr2XYOg3Hui4zGMNTJuJqa9SvLB4NIGWjQWT30+vVOrhXwVlZVehwXOV5gfQupc/BI8+xTbw6uz67Ucz4C4tVDxhjUP81oB13Mnva4yUa1mHi6p2MIMeR X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(164054003)(51704005)(479174004)(199003)(377454003)(189002)(24454002)(101416001)(189998001)(80316001)(110136002)(23676002)(50466002)(59896002)(77096005)(105586002)(4001350100001)(120886001)(87936001)(2950100001)(106466001)(36756003)(65816999)(76176999)(87266999)(54356999)(46102003)(50986999)(83506001)(92566002)(33656002)(62966003)(77156002)(86362001)(65956001)(47776003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR02MB1119;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR02MB1119; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:CY1PR02MB1119;BCL:0;PCL:0;RULEID:;SRVR:CY1PR02MB1119; X-Forefront-PRVS: 0576145E86 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2015 14:56:10.0778 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR02MB1119 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 27 On 5/14/2015 4:50 AM, Borislav Petkov wrote: > On Wed, May 13, 2015 at 12:37:04PM -0500, Aravind Gopalakrishnan wrote: >> >> mce_setup(&m); >> + rdmsrl(MSR_IA32_MCG_STATUS, m.mcgstatus); > Any meaningful bits in that MSR we wanna know when getting a > thresholding or deferred error? Are they even defined? Ah. Good point. RIPV is not defined for Deferred errors. For thresholding, we'll hit the interrupt handler only if we hit the threshold and it is not UC error (for which RIPV is not defined). Else, the counter would be incremented, but it would cause a #MC anyway. > If yes, RIPV should always be 1b, EIPV too, MCIP can't be set. > > -ENOMOREUSEFULBITS. > Thanks, -Aravind. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/