Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933469AbbENPJB (ORCPT ); Thu, 14 May 2015 11:09:01 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:33560 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbbENPI5 (ORCPT ); Thu, 14 May 2015 11:08:57 -0400 MIME-Version: 1.0 In-Reply-To: <1431613889-32737-1-git-send-email-javier.martinez@collabora.co.uk> References: <1431613889-32737-1-git-send-email-javier.martinez@collabora.co.uk> Date: Thu, 14 May 2015 08:08:56 -0700 X-Google-Sender-Auth: rEM_7vAFogl2sc2NbdqYFy63wAE Message-ID: Subject: Re: [PATCH 1/1] drm/bridge: ptn3460: Fix I2C ID table to match the reported modalias From: Doug Anderson To: Javier Martinez Canillas Cc: Thierry Reding , Olof Johansson , David Airlie , Ajay Kumar , Daniel Vetter , Krzysztof Kozlowski , linux-samsung-soc , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 44 Javier, On Thu, May 14, 2015 at 7:31 AM, Javier Martinez Canillas wrote: > I2C drivers that support OF, have both an I2C and OF device ID tables > that are used to fill the supported module aliases. But currently the > I2C core only uses the OF table to match a device with a driver and > the aliases information are always reported in the form i2c:. > > The client->name is used as the name postfix and when booting with OF > this is obtained with of_modalias_node() which drops the compatible > string vendor prefix. > > So for I2C drivers, the I2C and OF device ID tables should be keep in > sync in order to make module auto-loading to work but the I2C device > entries shouldn't have the vendor prefix since that is not reported. > > Before this patch: > > MODALIAS=i2c:ptn3460 > > $ modinfo | grep alias > alias: i2c:nxp,ptn3460 > alias: of:N*T*Cnxp,ptn3460* > > After this patch: > > MODALIAS=i2c:ptn3460 > > $ modinfo | grep alias > alias: i2c:ptn3460 > alias: of:N*T*Cnxp,ptn3460* > > Signed-off-by: Javier Martinez Canillas > --- > drivers/gpu/drm/bridge/ptn3460.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/