Date: Thu, 14 May 2015 16:20:32 +0100
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org
Subject: Re: [PATCH] Show proper respect for Heinrich Hertz by using the
 correct unit for frequency
Message-ID: <20150514152032.GA29132@n2100.arm.linux.org.uk>
References: <20150511131952.GD2067@n2100.arm.linux.org.uk>
 <5551217C.9090504@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5551217C.9090504@suse.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1698
Lines: 38

On Mon, May 11, 2015 at 11:39:08PM +0200, Andreas F?rber wrote:
> Am 11.05.2015 um 15:19 schrieb Russell King - ARM Linux:
> > The SI unit of frequency is Hertz, named after Heinrich Hertz, and is
> > given the symbol "Hz" to denote this.  "hz" is not the unit of frequency,
> > and is in fact meaningless.
> > 
> > Fix arch/arm to correctly use "Hz", thereby acknowledging Heinrich Hertz
> > contribution to the modern world.
> > 
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> 
> Nice. :) Since you're being exact, should it be "Hertz' contribution"?
> 
> > diff --git a/arch/arm/boot/dts/omap3-cm-t3517.dts b/arch/arm/boot/dts/omap3-cm-t3517.dts
> > index f5b5a1d96cd7..53ae04f9104d 100644
> > --- a/arch/arm/boot/dts/omap3-cm-t3517.dts
> > +++ b/arch/arm/boot/dts/omap3-cm-t3517.dts
> > @@ -66,7 +66,7 @@
> >  
> >  	otg_drv_vbus: pinmux_otg_drv_vbus {
> >  		pinctrl-single,pins = <
> > -			OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50Mhz_clk.usb0_drvvbus */
> > +			OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50MHz_clk.usb0_drvvbus */
> 
> This one looks like an identifier - did you check where it comes from
> and whether it needs to be fixed there as well?

There isn't any other reference to it in arch/arm (if there were, the
grep to find these would itself have found it.)

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/