Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422674AbbENPkJ (ORCPT ); Thu, 14 May 2015 11:40:09 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:42460 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S933570AbbENPkD (ORCPT ); Thu, 14 May 2015 11:40:03 -0400 X-Listener-Flag: 11101 Message-ID: <1431617997.15140.57.camel@mtksdaap41> Subject: Re: [PATCH 2/2] pwm: add Mediatek display PWM driver support From: YH Huang To: Matthias Brugger CC: Thierry Reding , Mark Rutland , Rob Herring , Pawel Moll , , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , srv_heupstream , , "Sascha Hauer" , Date: Thu, 14 May 2015 23:39:57 +0800 In-Reply-To: References: <1431336382-13167-1-git-send-email-yh.huang@mediatek.com> <1431336382-13167-3-git-send-email-yh.huang@mediatek.com> <20150512133202.GA24684@ulmo.nvidia.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2357 Lines: 70 On Tue, 2015-05-12 at 16:34 +0200, Matthias Brugger wrote: > 2015-05-12 15:32 GMT+02:00 Thierry Reding : > > On Mon, May 11, 2015 at 05:26:22PM +0800, YH Huang wrote: > >> Add display PWM driver support to modify backlight for MT8173/MT6595. > >> > >> Signed-off-by: YH Huang > >> --- > >> drivers/pwm/Kconfig | 9 ++ > >> drivers/pwm/Makefile | 1 + > >> drivers/pwm/pwm-disp-mediatek.c | 225 ++++++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 235 insertions(+) > >> create mode 100644 drivers/pwm/pwm-disp-mediatek.c > >> > >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > >> index b1541f4..9edbb5a 100644 > >> --- a/drivers/pwm/Kconfig > >> +++ b/drivers/pwm/Kconfig > >> @@ -111,6 +111,15 @@ config PWM_CLPS711X > >> To compile this driver as a module, choose M here: the module > >> will be called pwm-clps711x. > >> > >> +config PWM_DISP_MEDIATEK > > > > Please make this "PWM_MEDIATEK_DISP" so we can keep everything sorted by > > vendor. > > > >> + tristate "MEDIATEK display PWM driver" > > > > "MediaTek"? > > > >> + depends on OF > > > > Technically I think you need depends on HAS_IOMEM here to avoid breakage > > on randconfig builds. > > > >> + help > >> + Generic PWM framework driver for mediatek disp-pwm device. > > > > "MediaTek"? Also perhaps this should describe what this PWM is instead > > of just the "disp-pwm" which leaves everyone guessing what it is. From > > the name I'd expect it to be the PWM that is used to control the > > backlight brightness for display, but I think this description should > > say that explicitly. > > > >> + > >> + To compile this driver as a module, choose M here: the module > >> + will be called pwm-disp-mediatek. > > > > pwm-mediatek-disp > > I would prefert pwm-mtk-disp which is in line with the other drivers. > Also I have to admit that unfortunately the naming is not uniformly > throughout the kernel. > OK. I will take it. > Thanks, > Matthias Thank for your suggestion. Regards, YH Huang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/