Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933713AbbENRVw (ORCPT ); Thu, 14 May 2015 13:21:52 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:26132 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752903AbbENRSH (ORCPT ); Thu, 14 May 2015 13:18:07 -0400 X-IronPort-AV: E=Sophos;i="5.13,430,1427760000"; d="scan'208";a="265173322" From: Julien Grall To: CC: , , , , , Julien Grall , Konrad Rzeszutek Wilk , Boris Ostrovsky , "David Vrabel" Subject: [RFC 10/23] xen/biomerge: WORKAROUND always says the biovec are not mergeable Date: Thu, 14 May 2015 18:00:50 +0100 Message-ID: <1431622863-28575-11-git-send-email-julien.grall@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1431622863-28575-1-git-send-email-julien.grall@citrix.com> References: <1431622863-28575-1-git-send-email-julien.grall@citrix.com> MIME-Version: 1.0 Content-Type: text/plain X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1284 Lines: 37 When Linux is using 64K page granularity, every page will be slipt in multiple non-contiguous 4K MFN. I'm not sure how to handle efficiently the check to know whether we can merge 2 biovec with a such case. So for now, always says that biovec are not mergeable. Signed-off-by: Julien Grall Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: David Vrabel --- drivers/xen/biomerge.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/xen/biomerge.c b/drivers/xen/biomerge.c index 0edb91c..20387c2 100644 --- a/drivers/xen/biomerge.c +++ b/drivers/xen/biomerge.c @@ -9,6 +9,9 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1, unsigned long mfn1 = pfn_to_mfn(page_to_pfn(vec1->bv_page)); unsigned long mfn2 = pfn_to_mfn(page_to_pfn(vec2->bv_page)); + /* TODO: Implement it correctly */ + return 0; + return __BIOVEC_PHYS_MERGEABLE(vec1, vec2) && ((mfn1 == mfn2) || ((mfn1+1) == mfn2)); } -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/