Message-ID: <5554E715.7070203@broadcom.com>
Date: Thu, 14 May 2015 11:19:01 -0700
From: Scott Branden <sbranden@broadcom.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Mark Brown <broonie@kernel.org>
CC: Jonathan Richardson <jonathar@broadcom.com>,
        Dmitry Torokhov <dtor@google.com>, Anatol Pomazau <anatol@google.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        "Kumar Gala" <galak@codeaurora.org>, <linux-kernel@vger.kernel.org>,
        <linux-spi@vger.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.
References: <1431452293-16697-1-git-send-email-jonathar@broadcom.com> <1431452293-16697-3-git-send-email-jonathar@broadcom.com> <20150512191718.GW3066@sirena.org.uk> <5553E31A.8060309@broadcom.com> <5553E9FA.4070708@broadcom.com> <20150514103144.GO2761@sirena.org.uk>
In-Reply-To: <20150514103144.GO2761@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1821
Lines: 40

Hi Mark,

On 15-05-14 03:31 AM, Mark Brown wrote:
> On Wed, May 13, 2015 at 05:19:06PM -0700, Scott Branden wrote:
>
>> The purpose of this mspi interface is to connect to NOR flash.  There are
>> other SPI interfaces on the devices used to connect to other SPI devies.  We
>> don't have any need to support full duplex slaves on this port (NOR have any
>> hardware wired this way - pun realized after typing this).
>
> Chip vendors often say this sort of thing and then get surprised by what
> their users choose to do, and even if it only ever gets used with flash
> all it would take is some new flash command which can use full duplex
> for something.  Please write the code so it at least tries to handle
> full duplex operation, if you can't test it fully that's not the end of
> the world.  It doesn't look like it should be particularly difficult.
>
Yes, there is always room for improvements in code.  In this case - it 
really is not worth our time to add code we can't test.  We try to 
deliver code that we can test and actually works.  Yes, if anyone needs 
to use the mspi for full duplex operation code can be added in the 
future - it is software.  This block has gone through many generations 
of our SoCs and has only been used for this purpose - the bootROM boots 
from this SPI only.  It is dedicated for this purpose.

Also, there are other SPI blocks on the SoC that are used for connect 
other SPI devices.  These SPI blocks are properly designed for 
full-duplex operation.  This mspi block is designed for connecting to 
NOR flash.

Regards,
Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/