Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030277AbbENUMu (ORCPT ); Thu, 14 May 2015 16:12:50 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40337 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964879AbbENUMr (ORCPT ); Thu, 14 May 2015 16:12:47 -0400 Date: Thu, 14 May 2015 21:12:21 +0100 From: Mark Brown To: Jonathan Richardson Cc: Scott Branden , Dmitry Torokhov , Anatol Pomazau , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, bcm-kernel-feedback-list , devicetree@vger.kernel.org Message-ID: <20150514201221.GX2761@sirena.org.uk> References: <1431452293-16697-1-git-send-email-jonathar@broadcom.com> <1431452293-16697-3-git-send-email-jonathar@broadcom.com> <20150512191718.GW3066@sirena.org.uk> <5553E31A.8060309@broadcom.com> <5553E9FA.4070708@broadcom.com> <20150514103144.GO2761@sirena.org.uk> <5554E715.7070203@broadcom.com> <20150514190823.GR2761@sirena.org.uk> <5554FDB4.50809@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tvtG/WQWmfqkB9kQ" Content-Disposition: inline In-Reply-To: <5554FDB4.50809@broadcom.com> X-Cookie: 13. ... r-q1 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver. X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1643 Lines: 42 --tvtG/WQWmfqkB9kQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 14, 2015 at 12:55:32PM -0700, Jonathan Richardson wrote: > On 15-05-14 12:08 PM, Mark Brown wrote: > > All it takes is one hardware engineer who sees a SPI controller and a > > GPIO they can use for chip select; I wouldn't be so sure that nobody > > ever fixed this up locally (or happened to use a device that only needed > > single duplex). > Hi Mark. Would it help if we just set the flags to half duplex using > SPI_MASTER_HALF_DUPLEX when we register the master? That would deal with the data corruption issues, yes. Though it seems like there are some people who want full duplex support here - I don't know if any of them can point you at suitable hardware to test? --tvtG/WQWmfqkB9kQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVVQGkAAoJECTWi3JdVIfQa74H/0w3k4rEjSKo2cIArSVb45X+ pqZzxht4+cfRjdBkrEZHKVSz15m04xNL23Lch/9Z6Z3G8uIWlw2yaoD3R38E63s5 jLz14PmvxOYeIaUcgdLhv3o2cK+pCDlRiobmOTBvDaPyHyD89mWeEhpZg7KrVDG6 6G+6TYMEfJEfBNuIbl6JWyIa6Q+CcSTlSWg3cNSLjK7q9/gJYEi0LbFSaEu4mkS7 kVYaGILDUpUIb1/fKvSM3axvV2V3Snv9+uWRp3KjRXx/WQhHwahAiwxVxtqJLI4n xcxteAPB39xf4nb2XuJnZtXTuISBHOKQ7ReRTuWnGlxJBhfoVU0kJlOHy5PuA44= =wgzK -----END PGP SIGNATURE----- --tvtG/WQWmfqkB9kQ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/