Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030339AbbENUS7 (ORCPT ); Thu, 14 May 2015 16:18:59 -0400 Received: from mail-by2on0072.outbound.protection.outlook.com ([207.46.100.72]:11547 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030248AbbENUSz (ORCPT ); Thu, 14 May 2015 16:18:55 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; gmail.com; dkim=none (message not signed) header.d=none; Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none; Message-ID: <555501E8.105@opensource.altera.com> Date: Thu, 14 May 2015 15:13:28 -0500 From: Dinh Nguyen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: , , , , , , , , , , CC: , , , , , Subject: Re: [PATCH 2/4] edac, altera: Refactor EDAC for Altera CycloneV SoC. References: <1431553787-27741-1-git-send-email-tthayer@opensource.altera.com> <1431553787-27741-3-git-send-email-tthayer@opensource.altera.com> In-Reply-To: <1431553787-27741-3-git-send-email-tthayer@opensource.altera.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BLUPR08CA0051.namprd08.prod.outlook.com (10.141.200.31) To BLUPR03MB1362.namprd03.prod.outlook.com (25.163.80.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;2:J/bKj62hvkSTFFXMb3ppRDgKxFTKT8hbGwOYHF6lOSFrq+H0WO9pIsvwc+UZulx7;2:2mb5LneINHe+zLXLbWtDtveaFXbb6k17yRs89HVlVLwCNaCjd8FBcV4OFc2RfmlLcdDBcoVnHvbTsTp+ZMlWuaAeYTQC1sKbMQjtIbsb/24Mf68NQ+rvuO2h+S6LzxO+mPULcer3pdbZxc3Nw0G6Zw==;6:LM4EdSyuyMbKmkxqVcvf/0dw2ZKYM09YQp183pGDwfck60veAdaV+GeZGpq9bTBFN8VF5cPViSL8A7ts8CHjd/jFLryk5CRfUJVchbr5WiFKPJXkyOii+PUXnh0u5HByFFKy2PXOGixY0POVczN9xw==;3:m1XGUMi2oZFw5ZIXWd/I3HvgEpdw0/soBHmNQnleBBTWwfeLGUZyfcSyZM/JPGktxNBEN2MqAccOTcBSuLM00cD8Z5/z6j/JcSrs7tFT+wXcpp63OKiji6+bVSkbEKtaC4aa4t56ojtOjT5mZUGDk96re4o0WZi3owkR+LMbBMg9ha68NRG4PzcQJGVbr3m/GG1IQ3tsDYMAwIAp6gZJJjqT1pVCsg/EDGnxMWi8fzqW2HNsSsXuhJ4o0KZ9OpFTTJBmeCRkw3OpeT0WH53ReKF9VeCVDnjWQIsX5dQCdTo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1362;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1500; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BLUPR03MB1362;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1362;BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY1PR03MB1500;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1500; X-Forefront-PRVS: 0576145E86 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(24454002)(51704005)(377454003)(479174004)(77096005)(83506001)(33656002)(5001960100002)(65956001)(2201001)(46102003)(66066001)(65816999)(50986999)(76176999)(54356999)(42186005)(189998001)(47776003)(5001770100001)(122386002)(4001350100001)(92566002)(50466002)(62966003)(77156002)(2950100001)(40100003)(19580395003)(23746002)(87976001)(86362001)(19580405001)(921003)(2004002)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1362;H:[137.57.160.210];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;BLUPR03MB1362;9:AHs5iFqqO4y/+fOlgodIE5poq0eO+YBBKtb2+T?= =?Windows-1252?Q?xcUnTwkIBraP3wCj/7Fc1mhfetyZxJbB9xjlVnm9QTX5n9ckOkbe6wPZ?= =?Windows-1252?Q?mC5ON9wfT2rGegPsA1lKCStieIQ/uil5YcOLBjW2DiZGDQKGT302ifQw?= =?Windows-1252?Q?1inBxoEk8ZNkg0TY2ztweDlq00vAyy484In1L2ztFpu8BKvKIQ0DdAWf?= =?Windows-1252?Q?y5ywzZlMZLng6uYikQGv0i5sJtbgYpBykfc+9UzP0WqM1kfz9UA4KYV0?= =?Windows-1252?Q?r9Zftm4aY6jmpf92n0pCjFfow+UMDKxLlUnBJ54AVcNyiPftIvBI5yGx?= =?Windows-1252?Q?66qQK77ir7dSpnFnT3AVTk+c3JT57wDkkeQ6oTUV6UshiK3+ZBnSmuCo?= =?Windows-1252?Q?c7F//E6pVDrz0aYFgxqwYoi1Hngl2n4H+I3w96yu3mXfVqusv3IRFmrB?= =?Windows-1252?Q?JDZSSiF0h2JQSea2UmmlsZIImcwhRovd4dGkF3T8itdSxdqYRcChepbi?= =?Windows-1252?Q?uNReYRr4M+boaKYmtcu3nVwzcd1QC5mrV41+lg+iRuZ3Bcb3TRsnxI8C?= =?Windows-1252?Q?WuANCy3qIiNTX68oSE27NjUlqgSYgS/UPNyLTdafLAeeYXGFZyTPeXG8?= =?Windows-1252?Q?7xWim6IAk0pUaLzuOnKQiyTRNBVVTp1VjExqxYDG1GSvHYB/ZKr8+g46?= =?Windows-1252?Q?JViEyEFpM7tcAzyMicGsWpSUN2z8gb1EJ/2VcTi/9bTotvpDVG6j4JfP?= =?Windows-1252?Q?+zoPmzkXLWkoa8hkqZf3o3SO8g4r4vTkemaB9dTmvrTHd6+KzyVnVFhy?= =?Windows-1252?Q?G+bR2eo7Ii/rzlxTn3THtiSNatVApSmHMU6jhedZ7EQSMAUoXK1VTscQ?= =?Windows-1252?Q?X/if3lEtgEfD5FV3JmB7db7AGRiKprG1JLNIImxGZbt6hkzXZMB8wxPH?= =?Windows-1252?Q?+/bcWVwRM+gw/aUV2OHsh1Z1fld/Mtj8qctTTFWYrtFmNGpDGA8MHyWi?= =?Windows-1252?Q?d3NXiKlD++hhFUCaOyDq6nfjNbfftUmENkKgm0ERXgTechQ3d0NPUbKG?= =?Windows-1252?Q?8tsswGV0+83WFdQFbhacM16/R1o09OQ9Si?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;3:GnVMEcDaqSKrpnXaKFzsFMJfo7Lry1OpZRrUfQV4ZnKmV2vxp9+dv4qbD+/FkaCnsxDLIBAQ1fWsBpGAaMFm7S4JAz1xh+gMeCBYyfmvxDvYXWDi5fxm/Wpvb8zpLa8fIzLbp/Lf6a8yQ8Z2Kjf2VA==;10:2bXVGm8ST+ZAOPyMj+3iyDkRBClcLld6yffHlNCEgm2KtZhmVC21t2FTIPMwXHLS5J5Vfknuu6GOicQNaG1pYQQiNqwyq3mCTCxUBF7IIUA=;6:+Rs0iUe2l+KOslmjl+FRzm/Yl9g0nFmMWFhHe+1Lqo3caFu9CMITQQr9r4jJOKUDTPUOO4fhP6w3ZHzpLKtKUhDUDILBVrjKI2W4bnR7PssC7dZ9SUJzU/kAR8qzRRY0U655iMtZDlsr5Fe1lTUTUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1362 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1AFFO11FD017.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD017;1:GmyaRojmCxR6MGTEZ2W6qHZ077bsG3mbxpWtGpzypCitPPu1iQF9rEawp5M2OGfY+mpm6FkuflEFpg/eONoIfuifGUKKHN0q6fArYZL3wygOzSF37kuIyJv+rZZ4ayAdwQ3HkgeYCNrvMdNixny0XEPfQ8h+m4eBiKJsitrxiTsFHsczcFqGaVcJIMTtxR18z5c0ViOUDruYwfJ7Jgc+++DFvHW7zfuLCzRTmn5Hd3Px7PNrkaKJxnoC8vXatQbnc2OP1I2lX+1sC41GEz9pI+RdtNCKvqXTPl6MaOqiF2V6D+l2qx9b6sqwiTHlUi+7 X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(24454002)(199003)(51704005)(377454003)(479174004)(189002)(64126003)(16796002)(77096005)(6806004)(90366008)(85426001)(83506001)(33656002)(106466001)(5001960100002)(65806001)(65956001)(2201001)(46102003)(66066001)(65816999)(50986999)(76176999)(54356999)(189998001)(47776003)(5001770100001)(81156007)(122386002)(4001350100001)(92566002)(50466002)(62966003)(77156002)(2950100001)(40100003)(19580395003)(23746002)(87936001)(86362001)(19580405001)(105606002)(7099028)(921003)(2004002)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1500;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:ovrnspm;A:0;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1500;2:THvz+FdxCIf45AEiTR6dHA+o+pRW4dyZtL6g8bJgmfQ/TzYMwNo9pIDCC02fktGX;2:ijhYU9nY1QSQ6j7umj2Bzj/3DPnNj5S4YvxQ1FNcSCwcT6wMIIgWb8shGKkWWGorYl0sWH2Zed+uVZg2vGz75MEWCj9dPaFFUhsi/TzV83VnYS3ZLIzW0QambSi9CK2CUYTBYTejNWvlhV2eLAvG15eyc7VwEt/HFry+nhmw3Hxk47rwMeqZPzUjvXVDMKVOP0twKx8MatGJMsJ16LEv0RpOtLuZBfIBRYAfAYMAJ20=;6:vL0BS+PP96hc0jTF87P/pEb61PoAzDt6icP0OotbqFcWtevjsNjA+HNlr4Yi4nW7neHStC5uap0Rc22Par/3WA9Me+Bzwy53ZMbjyMIhR9xZI8z2+3/NsZ6AONByGdaOHSzMcZ840evd/BMxCnAnsA==;3:l67p7YPs/3oUT/CJWNT8pbxK+mCQrTJVq9NiFnMxbs3/ouazthm/CacvK6Qz3uPdIeBtX2Oe6Jep7E3XDeVAze5r9UljAwA0uqDSTYd1NDAQqBxvlGtmOHJRBwCs/P9hossb+MuJoqKCfhj6v8G+GTP0sZOIaqJY8xNyEpCQKIsyMXvamDWT9lfaasG2s99NmW5jtt8YDZo1j1KPF1giL+3C1I1VIzPmwMvDK05WyiWG/Hc/+90ou0ZzfwHN11IKTeP2/fxGmeeIp3QlaabHNHvGJMSln9qTvinXZA6jcHk= X-Forefront-PRVS: 0576145E86 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR03MB1500;9:pugbJIXiY7ApVk52WkXgC11iAPO/3DxtD+OP9v?= =?Windows-1252?Q?CmnIzZomqe4a+cjGU5Uf3uKUoa4pYzCk/xpM41f9a2yTz+7BTyrPuV+g?= =?Windows-1252?Q?L1nyVUnF9xfJ31EL779fGwYMy4yE9o9GzQGLkI8bOGbz5uVcY9a5k0iH?= =?Windows-1252?Q?CzRLcrl0kL/Cle7dwKFJdSCWKKCpRpb/lpbFsejmuzxuQA0As/QrfsG0?= =?Windows-1252?Q?tOyFkmJsKBsOXZaMrO0EwSbn0SGa+kFnW9zuMtO1GR+cgQSWVibWyTiQ?= =?Windows-1252?Q?4ztc1aMuRGUnXbSUovi5POAyX3wJsTfCwJUEHgtSVG9YhENMXRNlVZOm?= =?Windows-1252?Q?dkGeBMpijwpM6+9l5Rb4lYPirlxKS69rsa4Yz+T3JP7ED3bXXA/PhoA5?= =?Windows-1252?Q?KqiKH9IoQkEyiSAuUJPHfcP+NNU0EOLVXn1gyEiGCGuAVEkMcMBMwbW2?= =?Windows-1252?Q?5vcNc2P7HK6b9l0Ozik9KqOSecrIyTZVvbVKB1af7BaRm5eUm5pWwSpK?= =?Windows-1252?Q?fZ2e3ugiXnM1hgnz80oommq1omAXIOuBxi06Q84bIRL0mEWNG2D3Bs03?= =?Windows-1252?Q?vhM1eDHjpdo/DMFTDS+usgJPsy+SjpbViq7aX5K4y2iBseEkdTz3kFLq?= =?Windows-1252?Q?jTHcDnXqBpRkvmg8caWN9kV1keefv3hWzxJ35/xB+tt0nWf0QhRhpjdw?= =?Windows-1252?Q?joHwMp/OqvDo/gYpuEeJIz6CqAZfURMNIlz1a8eLaBuu1JILNr29g2Vz?= =?Windows-1252?Q?L2KQvFIW23QndRrRkLYKaDhcAZNYlGsdIEefUqBvNecrN1/Qf8xCUEZ9?= =?Windows-1252?Q?baEyMdRNB2zHLhjtlsFuBwbf244Bk75JWhptVfnY8dsRR89l0HoyEZvq?= =?Windows-1252?Q?uEFy/ZNVm48Uzak+RviENRm/0Q3CvugJMkV+Hvvglyr2tCNAzKPAFIVz?= =?Windows-1252?Q?MdKTHayLF2O/nwW6RRXC2wGsBBUR8j569Jg5gHtbiVIRj+zlJHTQ7ofM?= =?Windows-1252?Q?3sNg7db3Tvq6MEXANUA8VfXow/hek9kf5xNA0LtSIxS+CaN94yCfbkrV?= =?Windows-1252?Q?mWwNvvFszAzrAdFNXAVeF9ADgFDgfXWfY7ob1qxvYyyxOkJKkuvEY2vT?= =?Windows-1252?Q?5+EEwF2TRwE9GxztMFFV+1re4YFfFV+8YruY55m+tjFHmJ+M/cVonwEb?= =?Windows-1252?Q?zw3cbMXnCGxwcdm4dCRE+lCpGlGk/PTB+EVMYSwSQKf8LmxiI/+FHPyz?= =?Windows-1252?Q?koScLzUDpsPYyt9gHlT37y/rn1tW88+KDzbXNK36Nsk6h+3xPcf3Llsb?= =?Windows-1252?Q?iYM+fV2fsw/k1xjssGDn8qtw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1500;3:cSvl8gLuGfs9qXiSICIVtc3xT9MB9Q707J3RsfRvuEjnxzvpiRlgTTHyOsmPAVftJRDsahLD3BxqBYRtdgiwJCGxbWLWpV+xXQdt8aseBGN4rNjHAQWb7E5XLbNmcI1Sqa9qDyCPmGEm5z0hujv3Kw==;10:gXVsA1Xd/RXXMN+VDt7OKQDRWPGqpxDB01/kGieB9OfOqkDq0C8j3rqSee5h1631IjXD49zu/i7YtDvzqIWfQJkjBhlvmGV142F6uZAiSk4=;6:9Nw9ILdi1sJS2L4ubcK6gFNZ/kikET5j/zVzOdOC7xJfi+Y7e7nbt5Az4uqp3xEjQph6tRJs6I1xxLl9vlwBBHDUlzD1/tUmu2WNR+qG2YPk7X4jqCrLbAr0PmGQ/AFAaaXbpt0pGGcvJlU+M34tLA== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2015 20:18:51.3939 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1500 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1639 Lines: 44 On 05/13/2015 04:49 PM, tthayer@opensource.altera.com wrote: > From: Thor Thayer > > The Arria10 SOC uses a completely different SDRAM controller from the > earlier CycloneV and ArriaV SoCs. This patch abstracts the SDRAM bits > for the CycloneV/ArriaV SoCs in preparation for the Arria10 support. > > Signed-off-by: Thor Thayer > --- > drivers/edac/altera_edac.c | 194 ++++++++++++++++++++------------------------ > drivers/edac/altera_edac.h | 116 ++++++++++++++++++++++++++ > 2 files changed, 206 insertions(+), 104 deletions(-) > create mode 100644 drivers/edac/altera_edac.h > > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c > index e18a205..204ad2d 100644 > --- a/drivers/edac/altera_edac.c > +++ b/drivers/edac/altera_edac.c > @@ -1,5 +1,5 @@ > /* > - * Copyright Altera Corporation (C) 2014. All rights reserved. > + * Copyright Altera Corporation (C) 2014-2015. All rights reserved. > * Copyright 2011-2012 Calxeda, Inc. > * > * This program is free software; you can redistribute it and/or modify it > @@ -28,111 +28,64 @@ > #include > #include > [...] > - > -/* Altera SDRAM Memory Controller data */ > -struct altr_sdram_mc_data { > - struct regmap *mc_vbase; > +const struct altr_sdram_prv_data c5_data = { This should be static. Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/