Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933865AbbENUvb (ORCPT ); Thu, 14 May 2015 16:51:31 -0400 Received: from down.free-electrons.com ([37.187.137.238]:41562 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933271AbbENUv3 (ORCPT ); Thu, 14 May 2015 16:51:29 -0400 From: Alexandre Belloni To: Eddie Huang Cc: rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH] rtc: mt6397: fix build on some 32bits platforms Date: Thu, 14 May 2015 22:51:18 +0200 Message-Id: <1431636678-29525-1-git-send-email-alexandre.belloni@free-electrons.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1612 Lines: 46 On some !ARM 32bits platforms, the following compilation error happens because of the division on a 64bits value in mtk_rtc_read_time(): drivers/built-in.o: In function `mtk_rtc_read_time': rtc-mt6397.c:(.text+0x265d13f): undefined reference to `__divdi3' rtc-mt6397.c:(.text+0x265d150): undefined reference to `__moddi3' Use div_s64() as done in rtc_time64_to_tm() to solve that. Reported-by: kbuild test robot Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mt6397.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index 8bed852e4961..c0090b698ff3 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -150,7 +150,7 @@ static int mtk_rtc_read_time(struct device *dev, struct rtc_time *tm) { time64_t time; struct mt6397_rtc *rtc = dev_get_drvdata(dev); - int sec, ret; + int days, sec, ret; do { ret = __mtk_rtc_read_time(rtc, tm, &sec); @@ -171,7 +171,8 @@ static int mtk_rtc_read_time(struct device *dev, struct rtc_time *tm) /* rtc_tm_to_time64 covert Gregorian date to seconds since * 01-01-1970 00:00:00, and this date is Thursday. */ - tm->tm_wday = (time / 86400 + 4) % 7; + days = div_s64(time, 86400); + tm->tm_wday = (days + 4) % 7; exit: return ret; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/