Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422976AbbENWjy (ORCPT ); Thu, 14 May 2015 18:39:54 -0400 Received: from mga01.intel.com ([192.55.52.88]:8239 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161132AbbENWjs (ORCPT ); Thu, 14 May 2015 18:39:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,431,1427785200"; d="scan'208";a="571583922" Subject: Re: [Open-FCoE] [PATCH] scsi: fix Wunused-but-set-variable buildwarning From: "vasu.dev@linux.intel.com" To: Nicholas Mc Guire Cc: Vasu Dev , fcoe-devel@open-fcoe.org, "James E.J. Bottomley" , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org In-Reply-To: <1431627166-12729-1-git-send-email-hofrat@osadl.org> References: <1431627166-12729-1-git-send-email-hofrat@osadl.org> Content-Type: text/plain; charset="UTF-8" Date: Thu, 14 May 2015 15:39:47 -0700 Message-ID: <1431643187.4358.2.camel@lin-nd1-054.jf.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1873 Lines: 52 On Thu, 2015-05-14 at 20:12 +0200, Nicholas Mc Guire wrote: > commit "[SCSI] libfc: remove tgt_flags from fc_fcp_pkt struct" > removed the last usage of rpriv (rpriv->flags) but forgot to remove > the unused rpriv struct resulting in: > drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand': > drivers/scsi/libfc/fc_fcp.c:1795:30: warning: variable 'rpriv' set > but not used [-Wunused-but-set-variable] > so simply drop its declaration and setting. > > Patch was compile tested with x86_64_defconfig + SCSI_LOWLEVEL=y, > CONFIG_SCSI_FC_ATTRS=m, CONFIG_LIBFC=m > > Patch is against 4.1-rc3 (localversion-next is -next-20150514) > > Signed-off-by: Nicholas Mc Guire > --- > > drivers/scsi/libfc/fc_fcp.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c > index c438b81..fee6928 100644 > --- a/drivers/scsi/libfc/fc_fcp.c > +++ b/drivers/scsi/libfc/fc_fcp.c > @@ -1792,7 +1792,6 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd) > struct fc_lport *lport = shost_priv(shost); > struct fc_rport *rport = starget_to_rport(scsi_target(sc_cmd->device)); > struct fc_fcp_pkt *fsp; > - struct fc_rport_libfc_priv *rpriv; > int rval; > int rc = 0; > struct fc_stats *stats; > @@ -1814,8 +1813,6 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd) > goto out; > } > > - rpriv = rport->dd_data; > - > if (!fc_fcp_lport_queue_ready(lport)) { > if (lport->qfull) > fc_fcp_can_queue_ramp_down(lport); Looks good, Thx Acked-by: Vasu Dev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/