Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934047AbbEOA0n (ORCPT ); Thu, 14 May 2015 20:26:43 -0400 Received: from smtp.citrix.com ([66.165.176.89]:49063 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933771AbbEOA0k (ORCPT ); Thu, 14 May 2015 20:26:40 -0400 X-IronPort-AV: E=Sophos;i="5.13,431,1427760000"; d="scan'208";a="262911135" Date: Fri, 15 May 2015 01:26:37 +0100 From: Wei Liu To: Julien Grall CC: , , , , , , Wei Liu , Subject: Re: [RFC 08/23] net/xen-netback: Remove unused code in xenvif_rx_action Message-ID: <20150515002637.GD19352@zion.uk.xensource.com> References: <1431622863-28575-1-git-send-email-julien.grall@citrix.com> <1431622863-28575-9-git-send-email-julien.grall@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1431622863-28575-9-git-send-email-julien.grall@citrix.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1549 Lines: 42 On Thu, May 14, 2015 at 06:00:48PM +0100, Julien Grall wrote: > The variables old_req_cons and ring_slots_used are assigned but never > used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b "xen-netback: > always fully coalesce guest Rx packets". > > Signed-off-by: Julien Grall > Cc: Ian Campbell > Cc: Wei Liu > Cc: netdev@vger.kernel.org Acked-by: Wei Liu > --- > drivers/net/xen-netback/netback.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c > index 9c6a504..9ae1d43 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -515,14 +515,9 @@ static void xenvif_rx_action(struct xenvif_queue *queue) > > while (xenvif_rx_ring_slots_available(queue, XEN_NETBK_RX_SLOTS_MAX) > && (skb = xenvif_rx_dequeue(queue)) != NULL) { > - RING_IDX old_req_cons; > - RING_IDX ring_slots_used; > - > queue->last_rx_time = jiffies; > > - old_req_cons = queue->rx.req_cons; > XENVIF_RX_CB(skb)->meta_slots_used = xenvif_gop_skb(skb, &npo, queue); > - ring_slots_used = queue->rx.req_cons - old_req_cons; > > __skb_queue_tail(&rxq, skb); > } > -- > 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/