Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754144AbbEOGY4 (ORCPT ); Fri, 15 May 2015 02:24:56 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:34128 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753643AbbEOGYy (ORCPT ); Fri, 15 May 2015 02:24:54 -0400 From: Ricky Liang To: Mike Turquette , Stephen Boyd Cc: Ricky Liang , Matthias Brugger , James Liao , Sascha Hauer , Henry Chen , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC...), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC...) Subject: [PATCH] clk: mediatek: Initialize clk flags Date: Fri, 15 May 2015 14:22:45 +0800 Message-Id: <1431670969-1996-1-git-send-email-jcliang@chromium.org> X-Mailer: git-send-email 2.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 33 The variable init (struct clk_init_data) is allocated on the stack. We weren't initializing the .flags field, so it contains random junk, which can cause all kinds of interesting issues when the flags are parsed by clk_register. The best solution seems to just pass on the flags passed in to our clk_register wrappers. Signed-off-by: Ricky Liang --- drivers/clk/mediatek/clk-pll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c index 66154ca..72fe307 100644 --- a/drivers/clk/mediatek/clk-pll.c +++ b/drivers/clk/mediatek/clk-pll.c @@ -289,6 +289,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data, init.ops = &mtk_pll_ops; init.parent_names = &parent_name; init.num_parents = 1; + init.flags = data->flags; clk = clk_register(NULL, &pll->hw); -- 2.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/