Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754623AbbEOHOT (ORCPT ); Fri, 15 May 2015 03:14:19 -0400 Received: from hofr.at ([212.69.189.236]:52245 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754518AbbEOHOR (ORCPT ); Fri, 15 May 2015 03:14:17 -0400 Date: Fri, 15 May 2015 09:14:15 +0200 From: Nicholas Mc Guire To: Prasad Gondi Cc: Nicholas Mc Guire , Vasu Dev , "fcoe-devel@open-fcoe.org" , "James E.J. Bottomley" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" Subject: Re: [Open-FCoE] [PATCH] scsi: fix Wunused-but-set-variable buildwarning Message-ID: <20150515071415.GC24293@opentech.at> References: <1431627166-12729-1-git-send-email-hofrat@osadl.org> <1488e7d0337944d98996c115cd0baefc@EX13-MBX-026.vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488e7d0337944d98996c115cd0baefc@EX13-MBX-026.vmware.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 30 On Thu, 14 May 2015, Prasad Gondi wrote: > It seems like rpriv is used to set the fsp->tgt_flags originally > > > fsp->tgt_flags = rpriv->flags > > And fsp->tgt_flags are used in "fc_fcp_cmd_send" like this > > setup_timer(&fsp->timer, fc_fcp_timeout, (unsigned long)fsp); > if (rpriv->flags & FC_RP_FLAGS_REC_SUPPORTED) > fc_fcp_timer_set(fsp, get_fsp_rec_tov(fsp)); > > Main purpose of this flags used is to set the correct TimeOut Value for fc_fcp_timer. > > So is the removal of the "fsp->tgt_flags = rpriv->flags" in fc_queuecommand() is intentional? Or by mistake? > thats something I can't say - but the commit message indicated that the removal of tgt_flags was intentional. > Once we clear that out we can see whether this change make sense? > yup - many thanks ! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/