Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933827AbbEOHuL (ORCPT ); Fri, 15 May 2015 03:50:11 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:57723 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932900AbbEOHuG (ORCPT ); Fri, 15 May 2015 03:50:06 -0400 Message-ID: <5555A4F3.40703@atmel.com> Date: Fri, 15 May 2015 09:49:07 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Nathan Sullivan , David Miller CC: , Subject: Re: [PATCH] net: macb: Add better comment for RXUBR handling References: <1431554496-11716-1-git-send-email-nathan.sullivan@ni.com> In-Reply-To: <1431554496-11716-1-git-send-email-nathan.sullivan@ni.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1523 Lines: 42 Le 14/05/2015 00:01, Nathan Sullivan a ?crit : > Describe the handler for RXUBR better with a new comment. > > Signed-off-by: Nathan Sullivan > Reviewied-by: Josh Cartwright > Reviewied-by: Ben Shelton Thanks Nathan: good that you've added this comment! Acked-by: Nicolas Ferre > --- > drivers/net/ethernet/cadence/macb.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 61aa570..5f10dfc 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -1037,6 +1037,12 @@ static irqreturn_t macb_interrupt(int irq, void *dev_id) > * add that if/when we get our hands on a full-blown MII PHY. > */ > > + /* There is a hardware issue under heavy load where DMA can > + * stop, this causes endless "used buffer descriptor read" > + * interrupts but it can be cleared by re-enabling RX. See > + * the at91 manual, section 41.3.1 or the Zynq manual > + * section 16.7.4 for details. > + */ > if (status & MACB_BIT(RXUBR)) { > ctrl = macb_readl(bp, NCR); > macb_writel(bp, NCR, ctrl & ~MACB_BIT(RE)); > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/