Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934313AbbEOIDe (ORCPT ); Fri, 15 May 2015 04:03:34 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:3398 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933435AbbEOID3 (ORCPT ); Fri, 15 May 2015 04:03:29 -0400 Subject: Re: [PATCH v2 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins To: Jiri Olsa References: <1431412917-101336-1-git-send-email-hekuang@huawei.com> <20150512123744.GF22341@krava.redhat.com> <55521B79.60202@zoho.com> <20150513145049.GF25652@krava.redhat.com> <55549B6F.3030701@huawei.com> <20150514133105.GC1313@krava.redhat.com> CC: hekuang , , , , , , From: He Kuang Message-ID: <5555A7DA.2090800@huawei.com> Date: Fri, 15 May 2015 16:01:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <20150514133105.GC1313@krava.redhat.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.110.54.65] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1179 Lines: 42 On 2015/5/14 21:31, Jiri Olsa wrote: > On Thu, May 14, 2015 at 08:56:15PM +0800, He Kuang wrote: > > SNIP > >>>> It seems new targets are needed. In the v2 patch, >>> >>> hum, I dont get it.. why ? >>> >>> dynamic-list-file gets rebuilt any time plugins are rebuilt.. >>> why not keep just the 'plugins' dependency? >> >> You can test your patch as following steps: >> >> $ touch ../lib/traceevent/plugin_function.c >> $ make >> CC plugin_function.o >> LD plugin_function-in.o >> LINK plugin_function.so >> GEN libtraceevent-dynamic-list >> >> perf is not rebuilt. There should be a 'GEN perf', right? > > hum, right.. so this is separated bug that was there even > without your change. I tried to kick my change to address > that and ended up with what you sent in v2 ;-) > > I have another comment for your v2, which I'll send right away > > thanks, > jirka > Ok, please review the new version. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/