Date: Fri, 15 May 2015 10:48:12 +0200
From: Ingo Molnar <mingo@kernel.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
        acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org,
        adrian.hunter@intel.com, dsahern@gmail.com, ast@plumgrid.com,
        daniel@iogearbox.net, brendan.d.gregg@gmail.com,
        masami.hiramatsu.pt@hitachi.com, linux-kernel@vger.kernel.org,
        lizefan@huawei.com, pi3orama@163.com
Subject: Re: [RFC PATCH v2 00/37] perf tools: introduce 'perf bpf' command to
 load eBPF programs.
Message-ID: <20150515084812.GA29128@gmail.com>
References: <1431676290-1230-1-git-send-email-wangnan0@huawei.com>
 <20150515080330.GA5277@gmail.com>
 <5555B119.5040201@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5555B119.5040201@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2785
Lines: 88


* Wangnan (F) <wangnan0@huawei.com> wrote:

>   perf tools: Set vmlinux_path__nr_entries to 0 in vmlinux_path__exit
>   tools lib traceevent: Install libtraceevent.a into libdir
>   tools: Allow other override features to check

Hm, to check what? Not sure I can parse this sentence at a glance.

>   tools: Add __aligned_u64 to types.h
>   tools lib bpf: Introduce 'bpf' library to tools
>   tools lib bpf: Allow set printing function
>   tools lib bpf: Define basic interface

So you changed 'tools perf' to 'perf tools', but you should probably 
find a better name for 'tools lib bpf' as well, say:

    bpf tools: Define basic interface

?

>   tools lib bpf: Open eBPF object file and do basic validation
>   tools lib bpf: Check swap according to EHDR
>   tools lib bpf: Iterater over elf sections to collect information

s/Iterater
  Iterate

s/elf
  ELF

>   tools lib bpf: Collect version and license from ELF

'ELF' is not a noun really. From ELF binaries? From ELF sections?

>   tools lib bpf: Collect map definitions
>   tools lib bpf: Collect config section in object
>   tools lib bpf: Collect symbol table in object files
>   tools lib bpf: Collect bpf programs from object files
>   tools lib bpf: Collect relocation sections from object file
>   tools lib bpf: Collect relocation instructions for each program
>   tools lib bpf: Clean elf memory after loading
>   tools lib bpf: Add bpf.c/h for common bpf operations
>   tools lib bpf: Create maps needed by object file
>   tools lib bpf: Relocate programs
>   tools lib bpf: Introduce bpf_load_program to bpf.c

s/bpf_load_program
  bpf_load_program

>   tools lib bpf: Load bpf programs in object file into kernel
>   tools lib bpf: Introduce accessors of bpf_program
>   tools lib bpf: Introduce accessors for struct bpf_object

so 'of' bpf_program, but 'for' struct bpf_object?

>   perf tools: Add new 'perf bpf' command
>   perf tools: Make perf depend on libbpf
>   perf bpf: Add 'perf bpf record' subcommand
>   perf bpf: Add bpf-loader and open elf object files

s/elf
  ELF

>   perf bpf: Collect all bpf programs
>   perf bpf: Parse probe points of eBPF programs during prepartion

s/prepartion
  preparation

>   perf bpf: Probe at kprobe points
>   perf bpf: Load eBPF object into kernel
>   perf tools: Add a bpf_wrapper global flag
>   perf tools: Add bpf_fd field to evsel and introduce new event syntax
>   perf bpf: Generate event argv for other commands
>   perf bpf: Pass generated arguments to cmd_record

s/cmd_record
  cmd_record()

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/