Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934428AbbEOLcg (ORCPT ); Fri, 15 May 2015 07:32:36 -0400 Received: from david.siemens.de ([192.35.17.14]:55755 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934343AbbEOLcc (ORCPT ); Fri, 15 May 2015 07:32:32 -0400 Message-ID: <5555D94E.5050401@siemens.com> Date: Fri, 15 May 2015 13:32:30 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: =?UTF-8?B?VGhpw6liYXVkIFdla3N0ZWVu?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] scripts/gdb: Remove useless global instruction References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1378 Lines: 42 On 2015-05-14 07:22, Thiébaud Weksteen wrote: > Signed-off-by: Thiébaud Weksteen > --- > scripts/gdb/linux/tasks.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py > index 89d38e1..0fa33b0 100644 > --- a/scripts/gdb/linux/tasks.py > +++ b/scripts/gdb/linux/tasks.py > @@ -20,7 +20,6 @@ task_type = utils.CachedType("struct task_struct") > > > def task_lists(): > - global task_type > task_ptr_type = task_type.get_type().pointer() > init_task = gdb.parse_and_eval("init_task").address > t = g = init_task > @@ -73,7 +72,6 @@ ia64_task_size = None > > > def get_thread_info(task): > - global thread_info_type > thread_info_ptr_type = thread_info_type.get_type().pointer() > if utils.is_target_arch("ia64"): > global ia64_task_size These are from my early Python days... Did you check all the other global statements as well? I bet there are more, e.g. the one in the last line above. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/