Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934495AbbEOLfL (ORCPT ); Fri, 15 May 2015 07:35:11 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:47740 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933403AbbEOLfH (ORCPT ); Fri, 15 May 2015 07:35:07 -0400 Date: Fri, 15 May 2015 12:34:48 +0100 From: Russell King - ARM Linux To: Sjoerd Simons Cc: Rob Herring , Tony Lindgren , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas Subject: Re: [PATCH 1/2] ARM: cache-l2c: Detect whether it's safe to unlock Message-ID: <20150515113448.GI2067@n2100.arm.linux.org.uk> References: <1431416355-7693-1-git-send-email-sjoerd.simons@collabora.co.uk> <1431416355-7693-2-git-send-email-sjoerd.simons@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431416355-7693-2-git-send-email-sjoerd.simons@collabora.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1039 Lines: 21 On Tue, May 12, 2015 at 09:39:14AM +0200, Sjoerd Simons wrote: > The L2C cache should only be unlocked when the cache is setup to allow > that. In the common case the l2x0 driver sets up the cache for that to > be the case (e.g. setting L310_AUX_CTRL_NS_LOCKDOWN on L2C-310), making > unlock safe. However when a secure firmware is in use, it may not be > possible for the L2c to be configured that way making unlocking unsafe. > > To handle that, for caches where special configuration is needed to allow > unlocking, check whether this has been setup before unlocking. I've come up with a different solution to this, which of course I prefer. I'll post the patches later today, thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/