Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934359AbbEOL6E (ORCPT ); Fri, 15 May 2015 07:58:04 -0400 Received: from smtp.citrix.com ([66.165.176.89]:53623 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933562AbbEOL6C (ORCPT ); Fri, 15 May 2015 07:58:02 -0400 X-IronPort-AV: E=Sophos;i="5.13,433,1427760000"; d="scan'208";a="263038453" Message-ID: <5555DF44.1070502@citrix.com> Date: Fri, 15 May 2015 13:57:56 +0200 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Bob Liu CC: , , , , , Subject: Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place References: <1431428504-6623-1-git-send-email-bob.liu@oracle.com> <5555C3DE.7090603@citrix.com> <5555D26B.8040002@oracle.com> <5555D4F8.40701@citrix.com> <5555D9EC.9030802@oracle.com> In-Reply-To: <5555D9EC.9030802@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 34 El 15/05/15 a les 13.35, Bob Liu ha escrit: > > On 05/15/2015 07:14 PM, Roger Pau Monné wrote: >> El 15/05/15 a les 13.03, Bob Liu ha escrit: >>> >>> On 05/15/2015 06:01 PM, Roger Pau Monné wrote: >>>> El 12/05/15 a les 13.01, Bob Liu ha escrit: >>>>> The right place for talk_to_blkback() to query backend features and transport >>>>> parameters is after backend entered XenbusStateInitWait. There is no problem >>>> >>>> talk_to_blkback doesn't gather any backend features, it just publishes >>>> the features supported by the frontend, which AFAICT can be done at any >>> >>> 1) But talk_tlkback will also allocate and initialize the request ring which >>> should be done after backend entered XenbusStateInitWait. >> >> Maybe setup_blkring should be moved to a more suitable location instead >> of moving the whole function? >> > > Most of other parts in talk_to_blkback() depends on setup_blkring() like write > out ring-ref and event-channel. My bad. Yes, I see that talk_to_blkback writes the ring info stuff, so yes, moving it as a whole to a more suitable place seems OK to me, but please re-write the commit message to be more clear. Roger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/