Message-ID: <5555E885.6000806@intel.com>
Date: Fri, 15 May 2015 20:37:25 +0800
From: Pan Xinhui <xinhuix.pan@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Nick Dyer <nick.dyer@itdev.co.uk>, linux-kernel@vger.kernel.org
CC: dmitry.torokhov@gmail.com, yanmin_zhang@linux.intel.com, mnipxh@163.com
Subject: Re: [PATCH V2] atmel: fix a race between fw_load and data free
References: <5555D639.90405@intel.com> <55548784.3080505@itdev.co.uk>
In-Reply-To: <55548784.3080505@itdev.co.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 798
Lines: 30

hi,
	yes, we can't guarantee MXT_FW_RESET_TIME is enough. patch v3 is sent out :)
thanks
xinhui

On 2015年05月14日 19:31, Nick Dyer wrote:
> Hi-
>
> This looks like a good tidy up, one minor comment:
>
> On 15/05/15 12:19, Pan Xinhui wrote:
>> +    mxt_wait_for_completion(data, &data->fw_load_completion,
>> +                    MXT_FW_RESET_TIME);
>
> this should probably just be
>
> wait_for_completion(&data->fw_load_completion);
>
> rather than timing out (the MXT_FW_RESET_TIME may not be an appropriate
> length anyway)
>
> cheers
>
> Nick
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/