Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422814AbbEOM6D (ORCPT ); Fri, 15 May 2015 08:58:03 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:54793 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422654AbbEOM57 (ORCPT ); Fri, 15 May 2015 08:57:59 -0400 Message-ID: <5555ED4F.5070003@roeck-us.net> Date: Fri, 15 May 2015 05:57:51 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Opensource [Steve Twiss]" , LINUXKERNEL , LINUXWATCHDOG , Wim Van Sebroeck CC: Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , Lee Jones , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Samuel Ortiz , Support Opensource Subject: Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver References: <6a51f163b99edfad9165ad29609abb072dbaa2b7.1431621833.git.stwiss.opensource@diasemi.com> <55555639.8090505@roeck-us.net> <6ED8E3B22081A4459DAC7699F3695FB7014B22B63A@SW-EX-MBX02.diasemi.com> In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7014B22B63A@SW-EX-MBX02.diasemi.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1570 Lines: 57 Hi Steve, On 05/15/2015 01:13 AM, Opensource [Steve Twiss] wrote: > Hi Guenter, > > Thank you for your comments again, > Here are my responses. > > Regards, > Steve > > On 15 May 2015 03:13, Guenter Roeck >> Subject: Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver >> > > [...] > [ ... ] >>> + >>> + irq = platform_get_irq_byname(pdev, "WDG_WARN"); >>> + if (irq < 0) { >>> + dev_err(wdt->hw->dev, "Failed to get IRQ.\n"); >>> + ret = irq; >>> + goto error; >> >> Just return; the label does not serve a useful purpose. Same for the other >> goto statements below. > > Agreed. This is changed now. > >> Also, is the interrupt mandatory ? All it does is to display a message. >> Looks very optional to me. > > It is a place holder for something more application specific. > I could remove it, but I figured it would just get re-added when somebody takes the > driver and modifies it for their needs. > > If this is a problem however, it can go. > Please advise .. > Then this someone should add the code. For the time being, it just increases kernel size and may cause the driver to fail for no good reason. Plus, given the driver apparently works without interrupt, even then it should be optional, and the driver does not have to fail loading if it is not supported on a given platform. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/