Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934515AbbEONKZ (ORCPT ); Fri, 15 May 2015 09:10:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59822 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934256AbbEONKX (ORCPT ); Fri, 15 May 2015 09:10:23 -0400 Message-ID: <5555F03D.3010309@suse.cz> Date: Fri, 15 May 2015 15:10:21 +0200 From: Vlastimil Babka User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Kirill A. Shutemov" , Andrew Morton , Andrea Arcangeli , Hugh Dickins CC: Dave Hansen , Mel Gorman , Rik van Riel , Christoph Lameter , Naoya Horiguchi , Steve Capper , "Aneesh Kumar K.V" , Johannes Weiner , Michal Hocko , Jerome Marchand , Sasha Levin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv5 10/28] mm, vmstats: new THP splitting event References: <1429823043-157133-1-git-send-email-kirill.shutemov@linux.intel.com> <1429823043-157133-11-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1429823043-157133-11-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2317 Lines: 68 On 04/23/2015 11:03 PM, Kirill A. Shutemov wrote: > The patch replaces THP_SPLIT with tree events: THP_SPLIT_PAGE, > THP_SPLIT_PAGE_FAILT and THP_SPLIT_PMD. It reflects the fact that we > are going to be able split PMD without the compound page and that > split_huge_page() can fail. > > Signed-off-by: Kirill A. Shutemov > Acked-by: Christoph Lameter > Tested-by: Sasha Levin Acked-by: Vlastimil Babka > --- > include/linux/vm_event_item.h | 4 +++- > mm/huge_memory.c | 2 +- > mm/vmstat.c | 4 +++- > 3 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index 2b1cef88b827..3261bfe2156a 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -69,7 +69,9 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > THP_FAULT_FALLBACK, > THP_COLLAPSE_ALLOC, > THP_COLLAPSE_ALLOC_FAILED, > - THP_SPLIT, > + THP_SPLIT_PAGE, > + THP_SPLIT_PAGE_FAILED, > + THP_SPLIT_PMD, > THP_ZERO_PAGE_ALLOC, > THP_ZERO_PAGE_ALLOC_FAILED, > #endif > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index ccbfacf07160..be6d0e0f5050 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1961,7 +1961,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) > > BUG_ON(!PageSwapBacked(page)); > __split_huge_page(page, anon_vma, list); > - count_vm_event(THP_SPLIT); > + count_vm_event(THP_SPLIT_PAGE); > > BUG_ON(PageCompound(page)); > out_unlock: > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 1fd0886a389f..e1c87425fe11 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -821,7 +821,9 @@ const char * const vmstat_text[] = { > "thp_fault_fallback", > "thp_collapse_alloc", > "thp_collapse_alloc_failed", > - "thp_split", > + "thp_split_page", > + "thp_split_page_failed", > + "thp_split_pmd", > "thp_zero_page_alloc", > "thp_zero_page_alloc_failed", > #endif > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/